From: Guenter Roeck <linux@roeck-us.net>
To: Josef Gajdusek <atx@atx.name>, jdelvare@suse.de
Cc: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH] drivers/hwmon/emc1403.c: add support for emc1412
Date: Sun, 11 May 2014 19:20:58 -0700 [thread overview]
Message-ID: <5370300A.8070102@roeck-us.net> (raw)
In-Reply-To: <536FFC55.2080009@roeck-us.net>
On 05/11/2014 03:40 PM, Guenter Roeck wrote:
[ ... ]
>>
>> id = i2c_smbus_read_byte_data(client, THERMAL_REVISION_REG);
>> - if (id != 0x01)
>> + if (id != 0x01 && id != 0x04) {
>> return -ENODEV;
>
> This should be a separate patch, as it applies to emc1403/emc1404 as well,
> so we can backport it into -stable.
>
Also, the chip datasheet suggests that chip revision 3 exists as well.
Given that, I would suggest to replace the revision number check with
something like
if (id < 0x01 || id > 0x04)
return -ENODEV;
Guenter
next prev parent reply other threads:[~2014-05-12 2:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 13:00 [PATCH] drivers/hwmon/emc1403.c: add support for emc1412 Josef Gajdusek
2014-05-11 22:40 ` Guenter Roeck
2014-05-12 2:20 ` Guenter Roeck [this message]
2014-05-12 6:10 ` Jean Delvare
2014-05-12 15:59 ` Guenter Roeck
2014-05-12 16:48 ` Jean Delvare
2014-05-12 18:09 ` Guenter Roeck
2014-05-11 22:47 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5370300A.8070102@roeck-us.net \
--to=linux@roeck-us.net \
--cc=atx@atx.name \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox