From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] ARM: at91/dt: sam9261: Fix PLL output ranges and other clocks divisors
Date: Mon, 12 May 2014 15:04:36 +0200 [thread overview]
Message-ID: <5370C6E4.3020509@atmel.com> (raw)
In-Reply-To: <1398243220-20874-1-git-send-email-alexandre.belloni@free-electrons.com>
Hi,
To the whole series:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
and pushed on at91-3.16-dt2
Thanks, bye,
On 23/04/2014 10:53, Alexandre Belloni :
> Argument 3 (OUT) and 4 (ICPLL) of the atmel,pll-clk-output-ranges were missing.
> Also, the at91sam9261 doesn't really have a by 3 divisor.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/boot/dts/at91sam9261.dtsi | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9261.dtsi b/arch/arm/boot/dts/at91sam9261.dtsi
> index 561addceb81e..3ff239b26d72 100644
> --- a/arch/arm/boot/dts/at91sam9261.dtsi
> +++ b/arch/arm/boot/dts/at91sam9261.dtsi
> @@ -564,7 +564,8 @@
> reg = <0>;
> atmel,clk-input-range = <1000000 32000000>;
> #atmel,pll-clk-output-range-cells = <4>;
> - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
> + atmel,pll-clk-output-ranges = <80000000 200000000 0 1>,
> + <190000000 240000000 2 1>;
> };
>
> pllb: pllbck {
> @@ -575,7 +576,8 @@
> reg = <1>;
> atmel,clk-input-range = <1000000 32000000>;
> #atmel,pll-clk-output-range-cells = <4>;
> - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
> + atmel,pll-clk-output-ranges = <80000000 200000000 0 1>,
> + <190000000 240000000 2 1>;
> };
>
> mck: masterck {
> @@ -584,13 +586,13 @@
> interrupts-extended = <&pmc AT91_PMC_MCKRDY>;
> clocks = <&clk32k>, <&main>, <&plla>, <&pllb>;
> atmel,clk-output-range = <0 94000000>;
> - atmel,clk-divisors = <1 2 4 3>;
> + atmel,clk-divisors = <1 2 4 0>;
> };
>
> usb: usbck {
> compatible = "atmel,at91rm9200-clk-usb";
> #clock-cells = <0>;
> - atmel,clk-divisors = <1 2 4 3>;
> + atmel,clk-divisors = <1 2 4 0>;
> clocks = <&pllb>;
> };
>
>
--
Nicolas Ferre
prev parent reply other threads:[~2014-05-12 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 8:53 [PATCH 1/3] ARM: at91/dt: sam9261: Fix PLL output ranges and other clocks divisors Alexandre Belloni
2014-04-23 8:53 ` [PATCH 2/3] ARM: at91/dt: sam9261: Add ssc2, SSC clocks and pcks Alexandre Belloni
2014-04-23 8:53 ` [PATCH 3/3] ARM: at91/dt: sam9rl: Fix PLL output range and mck divisors Alexandre Belloni
2014-04-23 9:45 ` Boris BREZILLON
2014-05-12 13:04 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5370C6E4.3020509@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox