From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758649AbaELOzC (ORCPT ); Mon, 12 May 2014 10:55:02 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:14128 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbaELOzB (ORCPT ); Mon, 12 May 2014 10:55:01 -0400 Message-ID: <5370E0C2.5070208@atmel.com> Date: Mon, 12 May 2014 16:54:58 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Boris BREZILLON , Alexandre Belloni CC: Jean-Christophe Plagniol-Villard , , Subject: Re: [PATCHv2] ARM: at91/dt: sam9261: Fix PLL output ranges and other clocks divisors References: <1399904532-3688-1-git-send-email-alexandre.belloni@free-electrons.com> <5370D9E0.4000509@free-electrons.com> In-Reply-To: <5370D9E0.4000509@free-electrons.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/05/2014 16:25, Boris BREZILLON : > > On 12/05/2014 16:22, Alexandre Belloni wrote: >> Argument 3 (OUT) and 4 (ICPLL) of the atmel,pll-clk-output-ranges were missing. >> Also, the at91sam9261 doesn't really have a by 3 divisor. >> >> Signed-off-by: Alexandre Belloni > Acked-by: Boris Brezillon Ok, thanks guys, I have just updated the at91-3.16-dt2 branch with this modification. Bye, >> --- >> Changed in v2: >> After getting feedback from the atmel HW engineers, it appears that PLLB is not >> the same as PLLA despite what the datasheet seems to imply. The patch is updated >> to reflect that. >> >> arch/arm/boot/dts/at91sam9261.dtsi | 11 ++++++----- >> 1 file changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/boot/dts/at91sam9261.dtsi b/arch/arm/boot/dts/at91sam9261.dtsi >> index 561addceb81e..44d9e5ab09c3 100644 >> --- a/arch/arm/boot/dts/at91sam9261.dtsi >> +++ b/arch/arm/boot/dts/at91sam9261.dtsi >> @@ -564,7 +564,8 @@ >> reg = <0>; >> atmel,clk-input-range = <1000000 32000000>; >> #atmel,pll-clk-output-range-cells = <4>; >> - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>; >> + atmel,pll-clk-output-ranges = <80000000 200000000 0 1>, >> + <190000000 240000000 2 1>; >> }; >> >> pllb: pllbck { >> @@ -573,9 +574,9 @@ >> interrupts-extended = <&pmc AT91_PMC_LOCKB>; >> clocks = <&main>; >> reg = <1>; >> - atmel,clk-input-range = <1000000 32000000>; >> + atmel,clk-input-range = <1000000 5000000>; >> #atmel,pll-clk-output-range-cells = <4>; >> - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>; >> + atmel,pll-clk-output-ranges = <70000000 130000000 1 1>; >> }; >> >> mck: masterck { >> @@ -584,13 +585,13 @@ >> interrupts-extended = <&pmc AT91_PMC_MCKRDY>; >> clocks = <&clk32k>, <&main>, <&plla>, <&pllb>; >> atmel,clk-output-range = <0 94000000>; >> - atmel,clk-divisors = <1 2 4 3>; >> + atmel,clk-divisors = <1 2 4 0>; >> }; >> >> usb: usbck { >> compatible = "atmel,at91rm9200-clk-usb"; >> #clock-cells = <0>; >> - atmel,clk-divisors = <1 2 4 3>; >> + atmel,clk-divisors = <1 2 4 0>; >> clocks = <&pllb>; >> }; >> > -- Nicolas Ferre