public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: George Spelvin <linux@horizon.com>
Cc: lasaine@lvk.cs.msu.su, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ntp: make is_error_status() use its argument
Date: Mon, 12 May 2014 20:15:43 -0700	[thread overview]
Message-ID: <53718E5F.7050300@linaro.org> (raw)
In-Reply-To: <20140513030144.32557.qmail@ns.horizon.com>

On 05/12/2014 08:01 PM, George Spelvin wrote:
>> CONFIG_NTP_PPS not CONFIG_SMP, right?
> D'oh, yes.  I just noticed that there were two versions and one was
> broken.  Somehow my search for the enclosing #ifdef was completely broken.
> (I could swear I saw CONFIG_SMP, but looking now it's not even mentioned
> in the file; maybe I switched editor windows?)

No worries. :)

>
>> Adding Alexander since he submitted the pps logic.
> Thank you; some of these issues of code provenance and "who the heck do
> I notify about this?" are a bit laborious to infer even with the help
> of the git logs.
tig blame <filename> is pretty amazing for this sort of thing.

thanks
-john


      reply	other threads:[~2014-05-13  3:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-12 13:35 [PATCH] ntp: make is_error_status() use its argument George Spelvin
2014-05-12 17:54 ` John Stultz
2014-05-12 20:10   ` Alexander Gordeev
2014-05-13  3:01   ` George Spelvin
2014-05-13  3:15     ` John Stultz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53718E5F.7050300@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=lasaine@lvk.cs.msu.su \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@horizon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox