From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751984AbaEMEQ2 (ORCPT ); Tue, 13 May 2014 00:16:28 -0400 Received: from sema.semaphore.gr ([78.46.194.137]:41979 "EHLO sema.semaphore.gr" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750743AbaEMEQ0 (ORCPT ); Tue, 13 May 2014 00:16:26 -0400 Message-ID: <53719C98.1010103@semaphore.gr> Date: Tue, 13 May 2014 07:16:24 +0300 From: Stratos Karafotis User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Yuyang Du CC: Dirk Brandewie , "Rafael J. Wysocki" , Viresh Kumar , Dirk Brandewie , "linux-pm@vger.kernel.org" , LKML , Doug Smythies Subject: Re: [RFC PATCH] cpufreq: intel_pstate: Change the calculation of next pstate References: <5368255D.3090207@semaphore.gr> <536BEE89.3040602@gmail.com> <536CECB4.1090109@semaphore.gr> <53712F4B.7000101@semaphore.gr> <20140512193453.GB9351@intel.com> <537198AE.3050100@semaphore.gr> <20140512200140.GA10676@intel.com> In-Reply-To: <20140512200140.GA10676@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/05/2014 11:01 μμ, Yuyang Du wrote: > On Tue, May 13, 2014 at 06:59:42AM +0300, Stratos Karafotis wrote: >> Hi, >> >> On 12/05/2014 10:34 μμ, Yuyang Du wrote: >>> On Mon, May 12, 2014 at 11:30:03PM +0300, Stratos Karafotis wrote: >>>> On 09/05/2014 05:56 μμ, Stratos Karafotis wrote: >>>> >>>> Next performance state = min_perf + (max_perf - min_perf) * load / 100 >>>> >>> Hi, >>> >>> This formula is fundamentally broken. You need to associate the load with its >>> frequency. >> >> Could you please explain why is it broken? I think the load should be >> independent from the current frequency. > > Why independent? The load not (somewhat) determined by that? > > Maybe, in some cases yes. But not always. For example, please consider a CPU running a tight "for" loop in 100MHz for a couple of seconds. This produces a load of 100%. It will produce the same load (100%) in any other frequency. Stratos