Re: [PATCH 08/10 V2] workqueue: rename manager_mutex to attach_mutex

Tejun Heo
2014-05-13T14:19:53Z

Hello,

On Tue, May 13, 2014 at 02:45:58PM +0800, Lai Jiangshan wrote:
> On 05/13/2014 06:01 AM, Tejun Heo wrote:
> > On Mon, May 12, 2014 at 02:56:20PM +0800, Lai Jiangshan wrote:
> >> manager_mutex is only used to protect the attaching for the pool
> >> and the pool->workers list. It protects the pool->workers and operations
> >> based on this list, such as:
> >> cpu-binding for the workers in the pool->workers
> >> concurrency management for the workers in the pool->workers
> >
> > Concurrency management? What are you referring to?
>
> The operations to set/clear POOL_DISASSOCIATED and WORKER_UNBOUND
>
> Which words will be better if I don't use "Concurrency management"

Just be explicit and spell them out? Concurrency management in wq
context usually means nr_running tracking and the associated worker
suppression / wake up mechanism.

Thanks.

--
tejun