From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758756AbaEMGn5 (ORCPT ); Tue, 13 May 2014 02:43:57 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:59025 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758635AbaEMGnx (ORCPT ); Tue, 13 May 2014 02:43:53 -0400 Message-ID: <5371BEFD.6000407@ti.com> Date: Tue, 13 May 2014 12:13:09 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Vivek Gautam CC: Linux USB Mailing List , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , , Greg KH , Mark Rutland , robh+dt , Felipe Balbi , Kukjin Kim , Tomasz Figa , Sylwester Nawrocki , Kamil Debski , Jingoo Han Subject: Re: [PATCH v8 1/2] phy: Add new Exynos5 USB 3.0 PHY driver References: <1399643877-14528-1-git-send-email-gautam.vivek@samsung.com> <5370C689.2090402@ti.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday 13 May 2014 11:37 AM, Vivek Gautam wrote: > Hi Kishon, > > > On Mon, May 12, 2014 at 6:33 PM, Kishon Vijay Abraham I wrote: >> Hi Gautam, >> >> On Friday 09 May 2014 07:27 PM, Vivek Gautam wrote: >>> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >>> The new driver uses the generic PHY framework and will interact >>> with DWC3 controller present on Exynos5 series of SoCs. >>> >>> Also, created a new header file in linux/mfd/syscon/ for >>> Exynos5 SoCs and put the required PMU offset definitions >>> for the basic available PHYs. >>> >> >> >> I get the following checkpatch warnings >> >> WARNING: please write a paragraph that describes the config symbol fully >> #163: FILE: drivers/phy/Kconfig:163: >> +config PHY_EXYNOS5_USBDRD >> >> WARNING: DT compatible string "samsung,exynos5250-usbdrd-phy" appears >> un-documented -- check ./Documentation/devicetree/bindings/ >> #708: FILE: drivers/phy/phy-exynos5-usbdrd.c:516: >> + .compatible = "samsung,exynos5250-usbdrd-phy", >> >> WARNING: DT compatible string "samsung,exynos5420-usbdrd-phy" appears >> un-documented -- check ./Documentation/devicetree/bindings/ >> #711: FILE: drivers/phy/phy-exynos5-usbdrd.c:519: >> + .compatible = "samsung,exynos5420-usbdrd-phy",. >> >> >> I think you just need to separate the Documentation into a separate patch >> before applying the driver patch. >> > > I somehow don't see the Documentation warning. Below is the checkpatch > output which i ran on this v8 patch version. > linux-phy$ ./scripts/checkpatch.pl phy.patch > WARNING: please write a paragraph that describes the config symbol fully > #127: FILE: drivers/phy/Kconfig:163: > +config PHY_EXYNOS5_USBDRD > > total: 0 errors, 1 warnings, 760 lines checked > > phy.patch has style problems, please review. > > If any of these errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > am i missing something ? Yeah.. the checkpatch.pl has got updated recently. If you use the latest kernel you should see it. Thanks Kishon