public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <a.hajda@samsung.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Boris BREZILLON <boris.brezillon@free-electrons.com>
Cc: devicetree@vger.kernel.org,
	Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
	linux-doc@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [RFC PATCH 0/2] drm/panel: add simple-panel description using DT
Date: Tue, 13 May 2014 11:09:00 +0200	[thread overview]
Message-ID: <5371E12C.8000409@samsung.com> (raw)
In-Reply-To: <20140513075148.GF6754@ulmo>

On 05/13/2014 09:51 AM, Thierry Reding wrote:
> On Fri, May 09, 2014 at 04:16:40PM +0200, Boris BREZILLON wrote:
>> Hello Thierry,
>>
>> I noticed you're describing each new panel with a new entry in the
>> of_platform_match table and a new compatible string.
>> I guess you have a good reason to do it this way, because retrieving
>> panel description from DT would be pretty easy (see this series ;-)).
>>
>> Could tell me why you chose this approach ?
> 
> The reason is that devicetree mandates that a device be identified using
> a compatible value and that compatible value should be as specific as
> possible. That compatible value should give the device driver enough
> information to know everything it needs (resolution, timings, physical
> dimension).
> 
> Having all of that data in the device tree is redundant.
> 

Many panels I have encountered have no single timings, they accepts
ranges of timings. With 'compatible' approach there is no place to
configure timings specific for particular hw configuration, unless you
abuse somehow compatible string.

However it seems there are not so many cases the same panel must be used
with different timings on different boards, anyway it is a potential issue.

Regards
Andrzej

  reply	other threads:[~2014-05-13  9:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09 14:16 [RFC PATCH 0/2] drm/panel: add simple-panel description using DT Boris BREZILLON
2014-05-09 14:16 ` [RFC PATCH 1/2] drm/panel: add support for simple-panel description definition " Boris BREZILLON
2014-05-12 13:02   ` Boris BREZILLON
2014-05-09 14:16 ` [RFC PATCH 2/2] drm/panel: update simple-panel DT bindings doc with panel desc properties Boris BREZILLON
2014-05-13  7:53   ` Thierry Reding
2014-05-13  7:51 ` [RFC PATCH 0/2] drm/panel: add simple-panel description using DT Thierry Reding
2014-05-13  9:09   ` Andrzej Hajda [this message]
2014-05-13  9:20     ` Thierry Reding
2014-05-16  7:29   ` Boris BREZILLON

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5371E12C.8000409@samsung.com \
    --to=a.hajda@samsung.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jjhiblot@traphandler.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=rdunlap@infradead.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox