Re: [patch v2 4/4] mm, thp: do not perform sync compaction on pagefault

David Rientjes
2014-05-02T20:29:38Z

On Fri, 2 May 2014, Mel Gorman wrote:

> > The page locks I'm referring to is the lock_page() in __unmap_and_move()
> > that gets called for sync compaction after the migrate_pages() iteration
> > makes a few passes and unsuccessfully grabs it. This becomes a forced
> > migration since __unmap_and_move() returns -EAGAIN when the trylock fails.
> >
>
> Can that be fixed then instead of disabling it entirely?
>

We could return -EAGAIN when the trylock_page() fails for
MIGRATE_SYNC_LIGHT. It would become a forced migration but we ignore that
currently for MIGRATE_ASYNC, and I could extend it to be ignored for
MIGRATE_SYNC_LIGHT as well.

> > We have perf profiles from one workload in particular that shows
> > contention on i_mmap_mutex (anon isn't interesting since the vast majority
> > of memory on this workload [120GB on a 128GB machine] is has a gup pin and
> > doesn't get isolated because of 119d6d59dcc0 ("mm, compaction: avoid
> > isolating pinned pages")) between cpus all doing memory compaction trying
> > to fault thp memory.
> >
>
> Abort SYNC_LIGHT compaction if the mutex is contended.
>

Yeah, I have patches for that as well but we're waiting to see if they are
actually needed when sync compaction is disabled for thp. If we aren't
actually going to disable it entirely, then I can revive those patches if
the contention becomes such an issue.

> > That's one example that we've seen, but the fact remains that at times
> > sync compaction will iterate the entire 128GB machine and not allow an
> > order-9 page to be allocated and there's nothing to preempt it like the
> > need_resched() or lock contention checks that async compaction has.
>
> Make compact_control->sync the same enum field and check for contention
> on the async/sync_light case but leave it for sync if compacting via the
> proc interface?
>

Ok, that certainly can be done, I wasn't sure you would be happy with such
a change. I'm not sure there's so much of a difference between the new
compact_control->sync == MIGRATE_ASYNC and == MIGRATE_SYNC_LIGHT now,
though. Would it make sense to remove MIGRATE_SYNC_LIGHT entirely from
the page allocator, i.e. remove sync_migration entirely, and just retry
with a second call to compaction before failing instead?