Re: [RFC PATCH 6/6] mm, compaction: don't migrate in blocks that cannot be fully compacted in async direct compaction

Vlastimil Babka
2014-06-12T12:18:17Z

On 06/09/2014 11:06 AM, David Rientjes wrote:
> On Fri, 6 Jun 2014, Vlastimil Babka wrote:
>
>>> Agreed. I was thinking higher than 1GB would be possible once we have
>>> your series that does the pageblock skip for thp, I think the expense
>>> would be constant because we won't needlessly be migrating pages unless it
>>> has a good chance at succeeding.
>>
>> Looks like a counter of iterations actually done in scanners, maintained in
>> compact_control, would work better than any memory size based limit? It could
>> better reflect the actual work done and thus latency. Maybe increase the counter
>> also for migrations, with a higher cost than for a scanner iteration.
>>
>
> I'm not sure we can expose that to be configurable by userspace in any
> meaningful way. We'll want to be able to tune this depending on the size
> of the machine if we are to truly remove the need_resched() heuristic and
> give it a sane default. I was thinking it would be similar to
> khugepaged's pages_to_scan value that it uses on each wakeup.

Perhaps userspace can see the value in memory size unit, which would be
translated to pages_to_scan assuming the worst case, i.e. scanning each
page? Which would be used to limit the iterations, so if we end up
skipping blocks of pages instead of single pages for whatever reasons,
we can effectively scan a bigger memory size with the same effort?

>>> This does beg the question about parallel direct compactors, though, that
>>> will be contending on the same coarse zone->lru_lock locks and immediately
>>> aborting and falling back to PAGE_SIZE pages for thp faults that will be
>>> more likely if your patch to grab the high-order page and return it to the
>>> page allocator is merged.
>>
>> Hm can you explain how the page capturing makes this worse? I don't see it.
>>
>
> I was expecting that your patch to capture the high-order page made a
> difference because the zone watermark check doesn't imply the high-order
> page will be allocatable after we return to the page allocator to allocate
> it. In that case, we terminated compaction prematurely.

In fact compact_finished() uses both a watermark check and then a
free_list check. Only if both pass, it exits. But page allocation then
does another watermark check which may fail (due to its raciness and
drift) even though the page is still available on the free_list.

> If that's true,
> then it seems like no parallel thp allocator will be able to allocate
> memory that another direct compactor has freed without entering compaction
> itself on a fragmented machine, and thus an increase in zone->lru_lock
> contention if there's migratable memory.

I think it's only fair if someone who did the compaction work can
allocate the page. Another compaction then has to do its own work, so in
the end it's 2 units of work for 2 allocations (assuming success).
Without the fairness, it might be 2 units of work by single allocator,
for 2 successful allocations of two allocators. Or, as you seem to
imply, 1 unit of work for 1 successful allocation, because the one doing
the work will terminate prematurely and end up without allocation.
If we really rely on this premature termination as a contention
prevention, then it seems quite unfair and fragile to me.

> Having 32 cpus fault thp memory and all entering compaction and contending
> (and aborting because of contention, currently) on zone->lru_lock is a
> really bad situation.

I'm not sure if the premature termination could prevent this reliably. I
rather doubt that. The lock contention checks should work just fine in
this case. And also I don't think it's that bad if they abort due to
contention, if it happens quickly. It means that in such situation, it's
simply a better performance tradeoff to give up on THP and fallback to
4k allocation. Also you say "currently" but we are not going to change
that for lock contention, are we?