From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753913AbcC3Nvl (ORCPT <rfc822;w@1wt.eu>);
	Wed, 30 Mar 2016 09:51:41 -0400
Received: from mout.kundenserver.de ([217.72.192.73]:51906 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752921AbcC3Nvj (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 30 Mar 2016 09:51:39 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Rob Herring <robh@kernel.org>
Cc: Richard Weinberger <richard@nod.at>, Lee Jones <lee.jones@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
        user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM
Date: Wed, 30 Mar 2016 15:51:19 +0200
Message-ID: <5372571.zc5TeOVXyF@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CAL_Jsq+RHwzxfoEFsD_-uAZ7Y_CEdXvv8qamdXtcToeG-ENy7w@mail.gmail.com>
References: <1459275781-3863-1-git-send-email-robh@kernel.org> <6282729.XLLXSxbzQJ@wuerfel> <CAL_Jsq+RHwzxfoEFsD_-uAZ7Y_CEdXvv8qamdXtcToeG-ENy7w@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:j/NyM0m6iiJWGo8Us5HlS1xzxLZltiimhyeGMKwfLNKMuGAbSS+
 +BEf17JVMCHO3nCFtH0xDdNGVmV0oV8bQORsJTWPIrC/2qEY+Op5534zTgVczPkaxr+5m6a
 rvwV/nfuUZvEXmXnHodTg8SL+7fT8yHqyKfY2msKfslH6oRAHnNQkyHAU/fyZJELZp4NR18
 jsSoKRmCyPOGImm0XcGuQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:jCqdC1LVyC0=:gU9K1jdoXyTPNwXfrzuD1A
 Ra5OpdbxTLYO+dv9tERERyVVi9eGJzk9dmN54aMwWNl/wYUq8y2Kte2fpwDzWrOU8SwTxmrri
 eQf9aQiIjB0cr0YUCBuT25oVYiSxxhlYVkkT30H5W1ohxqjhzJ08J03uoJ0Sd+e7VtW/phr86
 MEhQe6/VHqa6xMVAbmO2mtXnXLY6HpI1WGrchuLGbP6IH9KOgm23kOqDypHjWomCUFpUDQrUS
 sXiksXEBvcb7l+HF+OhzP1x5yQgyVl/crCcBbax3gFlku1ugrzH6skHzqy4bT17eoOec84/9g
 6S2ZbPt/eCiERnOqnoWtrvYmNUYnEG/8WyK4gHRqQYHtSA7rFD+jLAxIFrpMrLzp5iJ5xixvG
 FujM/hjo8Ewc0lnk1oU/cGbgMdxqrQiFmXdVcIPlTsEebkWkLjjxL4OfNV8Y0Pw+EPt86ZeLy
 JImB2uOKlto0Ubj8xzEdYruhx3fz/HmAAlRRsQcTNT5FBZCssQxOEPTx1rch+tNtZY1RqLo2z
 ON/3d+4ltyFq3a/2x5rcMEYaPhwo9yYX19GRkljjVG2SxLhFbxZey63B6yzyNTdMRsGTG1ix8
 ZDNEzy8nZU1mzAuvxV5a/4dNmMImO75i12FYbiQJErbz6BVIqu3C+ChF+l2MrWNpVz1+T66UL
 GTOmwwQ8u2tVdt7SFDBbmzlQIwD5BmXZt7rh3zDVQ169g5t6NEbN8ON7o4Y1pturGu2gqbNH8
 OxVeXALyh6j/XJeh
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday 30 March 2016 08:29:45 Rob Herring wrote:
> On Wed, Mar 30, 2016 at 5:03 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Wednesday 30 March 2016 10:13:53 Richard Weinberger wrote:
> >>
> >> I fully understand your point of view. COMPILE_TEST is a monster that
> >> can do the heavy lifting for you, but monsters also have claws and fangs.
> >>
> >> Having COMPILE_TEST having depend on !UML works for me. But don't
> >> we have other archs without io mem? At least a few years ago while
> >> porting nandsim to UML I found s390 that lacks of io mem too.
> >
> > s390 gained IOMEM support when they started having PCI attachments.
> 
> I'm confused how s390 defines HAS_IOMEM and includes it from lib/Kconfig though.

Kconfig can define the same symbol multiple times, which is really
confusing. I only checked for NO_IOMEM, which s390 no longer defines,
but I have not checked what actually happens in case of two conflicting
definitions, where the one lib/Kconfig defaults to 'y' and the one in
arch/s390 defaults to CONFIG_PCI.

	Arnd