public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Luben Tuikov <ltuikov@yahoo.com>
To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	James Bottomley <James.Bottomley@suse.de>
Subject: SCSI reusing tags during error recovery
Date: Mon, 10 Jan 2011 10:21:16 -0800 (PST)	[thread overview]
Message-ID: <537305.92125.qm@web31812.mail.mud.yahoo.com> (raw)

Observed is on the wire, the following scenario:

0: Tag A (READ) -->
  (Times out)
1: Tag X (TMF ABORT TASK, TTBM=A) -->
2: Tag X (TMR FUNCTION COMPLETE) <--
3: Tag A (TUR) -->
4: Tag A (TUR status GOOD) <--
5: Tag A+2 (some command) -->
...

Undoubtedly resulting from the SCSI layer reusing the request
structure of the timed out Tag A to issue the Test Unit Ready
command, sequence 3.

However, if the task manager were unable to abort Tag A and
returned a different task management result, then the TUR would
complete with CHECK CONDITION (ABORTED COMMAND, OVERLAPPED
COMMANDS ATTEMPTED). Not all transports require the task router
to implement overlapped tag checking, and in most it is optional.
The TUR should go out with Tag A+1.

The SCSI layer should ideally, not perform error recovery ("error
handling" to use Linux' own terminology) on behalf of a timed out
request, but allow higher layers to issue TMF only based on a
ITLQ (tag, a number) or ITL (LUN, a structure) or IT nexus
(target port).

A previous issue I raised, tag generation for tags of task
management functions, can be found here:
http://marc.info/?l=linux-scsi&m=128902337522890&w=2

   Luben


                 reply	other threads:[~2011-01-10 18:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537305.92125.qm@web31812.mail.mud.yahoo.com \
    --to=ltuikov@yahoo.com \
    --cc=James.Bottomley@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox