* [patch] mtip32xx: blk_mq_init_queue() returns an ERR_PTR
@ 2014-05-14 12:54 Dan Carpenter
2014-05-14 14:07 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-05-14 12:54 UTC (permalink / raw)
To: Jens Axboe
Cc: Asai Thambi S P, Sam Bradshaw, Kent Overstreet, Alexander Gordeev,
linux-kernel, kernel-janitors
We changed this from blk_alloc_queue_node() to blk_mq_init_queue() so
the check needs to be updated as well.
Fixes: ee5036035df1 ('mtip32xx: convert to use blk-mq')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 3a0882e..5979ab3 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -3890,7 +3890,7 @@ skip_create_disk:
/* Allocate the request queue. */
dd->queue = blk_mq_init_queue(&dd->tags);
- if (dd->queue == NULL) {
+ if (IS_ERR(dd->queue)) {
dev_err(&dd->pdev->dev,
"Unable to allocate request queue\n");
rv = -ENOMEM;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] mtip32xx: blk_mq_init_queue() returns an ERR_PTR
2014-05-14 12:54 [patch] mtip32xx: blk_mq_init_queue() returns an ERR_PTR Dan Carpenter
@ 2014-05-14 14:07 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2014-05-14 14:07 UTC (permalink / raw)
To: Dan Carpenter
Cc: Asai Thambi S P, Sam Bradshaw, Kent Overstreet, Alexander Gordeev,
linux-kernel, kernel-janitors
On 2014-05-14 06:54, Dan Carpenter wrote:
> We changed this from blk_alloc_queue_node() to blk_mq_init_queue() so
> the check needs to be updated as well.
>
> Fixes: ee5036035df1 ('mtip32xx: convert to use blk-mq')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks Dan, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-14 14:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-14 12:54 [patch] mtip32xx: blk_mq_init_queue() returns an ERR_PTR Dan Carpenter
2014-05-14 14:07 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox