From: Nishanth Menon <nm@ti.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Chander Kashyap <chander.kashyap@linaro.org>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Chander Kashyap <k.chander@samsung.com>,
Inderpal Singh <inderpal.s@samsung.com>
Subject: Re: [PATCH] PM / OPP: discard duplicate OPP additions
Date: Wed, 14 May 2014 09:27:00 -0500 [thread overview]
Message-ID: <53737D34.5040307@ti.com> (raw)
In-Reply-To: <CAKohponfdoPG7H4h-5s+V7CwB_SgnyqqUm9aa6G-K_cX3DOcfA@mail.gmail.com>
On 05/14/2014 06:08 AM, Viresh Kumar wrote:
> On 14 May 2014 15:01, Chander Kashyap <chander.kashyap@linaro.org> wrote:
>>> say we do at this point:
>>> if (new_opp->rate == opp->rate) {
>>> dev_err(dev, "%s: attempt to add duplicate OPP entry (rate=%ld)\n",
>>> __func__, new_opp->rate)
>>> kfree(new_opp);
>>> return -EINVAL;
>>> }
>>
>> Yes this is more cleaner.
>> But instead of dev_err, we should use dev_warn and secondly
>
> Correct
>
>> return 0 rather than EINVAL, as there are independent users for this function
>
> Why? We should actually use EEXIST here instead of EINVAL though..
>
Yep -EEXIST is the right return value here. As Viresh indicated,
reporting back 0 when the requested operation actually was not
performed is wrong. Caller is supposed to know when it makes an error
- hiding it is not correct.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-05-14 14:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 7:41 [PATCH] PM / OPP: discard duplicate OPP additions [Chander Kashyap
2014-05-13 8:22 ` Viresh Kumar
2014-05-13 10:30 ` Sudeep Holla
2014-05-13 11:05 ` Viresh Kumar
2014-05-13 11:37 ` Sudeep Holla
2014-05-13 11:57 ` Chander Kashyap
2014-05-13 13:02 ` Sudeep Holla
2014-05-13 13:41 ` Nishanth Menon
2014-05-13 13:23 ` Nishanth Menon
2014-05-14 9:31 ` Chander Kashyap
2014-05-14 11:08 ` Viresh Kumar
2014-05-14 14:27 ` Nishanth Menon [this message]
2014-05-15 8:25 ` Chander Kashyap
2014-05-15 8:27 ` Viresh Kumar
2014-05-15 8:46 ` Chander Kashyap
2014-05-15 8:55 ` Viresh Kumar
2014-05-16 8:13 ` [PATCH v2] " Chander Kashyap
2014-05-14 15:02 ` [PATCH] " Pavel Machek
2014-05-15 3:57 ` Viresh Kumar
[not found] ` <CAOqmu80j2q6hQLThVt60QkjqcZTXwJ6ddwDLvqBEW1ejrVh_hw@mail.gmail.com>
2014-05-15 4:36 ` Viresh Kumar
2014-05-15 4:52 ` Inderpal Singh
2014-05-15 5:04 ` Viresh Kumar
2014-05-15 5:30 ` Inderpal Singh
2014-05-15 5:37 ` Viresh Kumar
2014-05-15 5:46 ` Inderpal Singh
2014-05-15 6:01 ` Viresh Kumar
2014-05-15 6:10 ` Inderpal Singh
2014-05-17 17:29 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53737D34.5040307@ti.com \
--to=nm@ti.com \
--cc=chander.kashyap@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=inderpal.s@samsung.com \
--cc=k.chander@samsung.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).