Re: [PATCH 1/7] apei, mce: Call MCE-specific code only for X86 architecture.

Borislav Petkov
2014-05-05T14:53:36Z

On Mon, May 05, 2014 at 04:34:41PM +0200, Tomasz Nowicki wrote:
> acpi_disable_cmcff as global value can switch off/on MC entries
> analysing via kernel args.

No, it switches off firmware first mode for correctable errors because
of buggy BIOSes - 9ad95879cd1b2 (what else...)

> This glob value resides in x86 ACPI code and has meaning only for MCE
> related mechanism,

Of course it doesn't!

> that is why I have moved it under hest_parse_cmc.

See APEI section in the ACPI spec "18.4 Firmware First Error Handling."

Regardless of what your version of APEI does, you actually shouldn't
need to touch acpi_disable_cmcff at all as it not arch-specific.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--