From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755487AbaEOQAc (ORCPT ); Thu, 15 May 2014 12:00:32 -0400 Received: from mga11.intel.com ([192.55.52.93]:6038 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751551AbaEOQA2 (ORCPT ); Thu, 15 May 2014 12:00:28 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,1060,1389772800"; d="scan'208";a="539657848" Message-ID: <5374E472.9030001@linux.intel.com> Date: Thu, 15 May 2014 23:59:46 +0800 From: "Li, Aubrey" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Andy Shevchenko CC: Heikki Krogerus , "Rafael J. Wysocki" , Mike Turquette , Mika Westerberg , Jin Yao , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 0/4] ACPI / LPSS: Solution for two issues seen on Asus T100 References: <1400161226-24067-1-git-send-email-heikki.krogerus@linux.intel.com> <5374D0A8.2090407@linux.intel.com> <1400165610.3703.41.camel@smile.fi.intel.com> In-Reply-To: <1400165610.3703.41.camel@smile.fi.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014/5/15 22:53, Andy Shevchenko wrote: > On Thu, 2014-05-15 at 22:35 +0800, Li, Aubrey wrote: >> On 2014/5/15 21:40, Heikki Krogerus wrote: >>> Changes since v1: >>> - now using do_div() in clk_fd_recalc_rate() as suggested by Andy >>> - NULL checks for clk_name allocation in acpi_lpss.c >>> >>> This combines two patch sets for LPSS that I had already send for >>> review separately. They conflicted with each other. >>> >>> The first two patches will fix a problem were the context of the >>> private LPSS registers is lost when entering D3. The last two will add >>> support for the M/N dividers on LPSS by adding a new basic clock type >>> for fractional dividers. The UART driver needs support for it in order >>> to get clock rates that suit the requested baud rates. >> >> The major issue in my mind is, this proposal makes a couple between I2C >> designware, HSUART, or probably DMA driver as well with LPSS driver. > > acpi_lpss driver creates platform devices for each found and enumerated > device. > If there no acpi_lpss enabled the drivers work as supposed without it. This is not true. Thanks, -Aubrey > I didn't see any contradiction here. > >> That is, currently without LPSS driver, I2C/HSUART won't work properly. >> So we at least need to describe this dependency in Kconfig. >> >> Thanks, >> -Aubrey >>> >>> >>> Heikki Krogerus (4): >>> ACPI / PM: Export rest of the subsys functions >>> ACPI / LPSS: custom power domain for LPSS >>> clk: new basic clk type for fractional divider >>> ACPI / LPSS: support for fractional divider clock >>> >>> drivers/acpi/acpi_lpss.c | 204 ++++++++++++++++++++++++++++++----- >>> drivers/acpi/device_pm.c | 2 + >>> drivers/clk/Makefile | 1 + >>> drivers/clk/clk-fractional-divider.c | 135 +++++++++++++++++++++++ >>> include/linux/acpi.h | 4 + >>> include/linux/clk-provider.h | 31 ++++++ >>> 6 files changed, 349 insertions(+), 28 deletions(-) >>> create mode 100644 drivers/clk/clk-fractional-divider.c >>> >> > >