From: RAGHAVENDRA GANIGA <ravi23ganiga@gmail.com>
To: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
a.zummo@towertech.it
Subject: query regarding not returning error if request_irq fails after rtc registration
Date: Thu, 15 May 2014 22:15:14 +0530 [thread overview]
Message-ID: <5374EF1A.2000609@gmail.com> (raw)
in ds1343 driver after the rtc is registered using devm_rtc_device_register
i am requesting irq using devm_request_threaded_irq, in case this request
fails instead of the driver bailing out it just uses dev_err to show the
error and the driver probe returns zero
my question is that the set_alarm and alarm_irq_enable is still active,
so should i use some flag in the global private variable of the driver
so that if the request irq fails, then using this flag the set_alarm
and alarm_irq_enable can return error since there is no irq handler
for the rtc interrupt
or is there any other solution
or let the set_alarm and alarm_irq_enable routine be as it is and will
not harm
Thanks and Regards
Raghavendra Chandra Ganiga
Contact: +919594554858
next reply other threads:[~2014-05-15 16:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 16:45 RAGHAVENDRA GANIGA [this message]
2014-05-15 16:56 ` query regarding not returning error if request_irq fails after rtc registration Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5374EF1A.2000609@gmail.com \
--to=ravi23ganiga@gmail.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox