* [PATCH] drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP
@ 2014-05-17 5:26 Chen Gang
2014-05-17 5:36 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Chen Gang @ 2014-05-17 5:26 UTC (permalink / raw)
To: roland, sean.hefty, hal.rosenstock
Cc: Guan Xuetao, matanb, davem, ogerlitz, eyalpe, amirv, sbohrer,
linux-rdma, linux-kernel@vger.kernel.org, netdev
'struct irq_affinity_notify' and the related functions are only defined
when SMP enabled, so at present, mlx4 has to only run under SMP.
The related error (allmodconfig under unicore32):
CC [M] drivers/net/ethernet/mellanox/mlx4/eq.o
drivers/net/ethernet/mellanox/mlx4/eq.c:58: error: field ‘notify’ has incomplete type
drivers/net/ethernet/mellanox/mlx4/eq.c: In function ‘mlx4_irq_notifier_notify’:
drivers/net/ethernet/mellanox/mlx4/eq.c:1094: error: type defaults to ‘int’ in declaration of ‘__mptr’
drivers/net/ethernet/mellanox/mlx4/eq.c:1094: warning: initialization from incompatible pointer type
drivers/net/ethernet/mellanox/mlx4/eq.c:1104: error: dereferencing pointer to incomplete type
drivers/net/ethernet/mellanox/mlx4/eq.c: In function ‘mlx4_release_irq_notifier’:
drivers/net/ethernet/mellanox/mlx4/eq.c:1111: error: type defaults to ‘int’ in declaration of ‘__mptr’
drivers/net/ethernet/mellanox/mlx4/eq.c:1111: warning: initialization from incompatible pointer type
drivers/net/ethernet/mellanox/mlx4/eq.c: In function ‘mlx4_assign_irq_notifier’:
drivers/net/ethernet/mellanox/mlx4/eq.c:1133: error: implicit declaration of function ‘irq_set_affinity_notifier’
make[5]: *** [drivers/net/ethernet/mellanox/mlx4/eq.o] Error 1
make[4]: *** [drivers/net/ethernet/mellanox/mlx4] Error 2
make[3]: *** [drivers/net/ethernet/mellanox] Error 2
make[2]: *** [drivers/net/ethernet] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/infiniband/hw/mlx4/Kconfig | 2 +-
drivers/net/ethernet/mellanox/mlx4/Kconfig | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/mlx4/Kconfig b/drivers/infiniband/hw/mlx4/Kconfig
index fc01dea..e31e400 100644
--- a/drivers/infiniband/hw/mlx4/Kconfig
+++ b/drivers/infiniband/hw/mlx4/Kconfig
@@ -1,6 +1,6 @@
config MLX4_INFINIBAND
tristate "Mellanox ConnectX HCA support"
- depends on NETDEVICES && ETHERNET && PCI && INET
+ depends on NETDEVICES && ETHERNET && PCI && INET && SMP
select NET_VENDOR_MELLANOX
select MLX4_CORE
---help---
diff --git a/drivers/net/ethernet/mellanox/mlx4/Kconfig b/drivers/net/ethernet/mellanox/mlx4/Kconfig
index 1486ce9..a1f2380 100644
--- a/drivers/net/ethernet/mellanox/mlx4/Kconfig
+++ b/drivers/net/ethernet/mellanox/mlx4/Kconfig
@@ -4,7 +4,7 @@
config MLX4_EN
tristate "Mellanox Technologies 1/10/40Gbit Ethernet support"
- depends on PCI
+ depends on PCI && SMP
select MLX4_CORE
select PTP_1588_CLOCK
---help---
--
1.9.2.459.g68773ac
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP
2014-05-17 5:26 [PATCH] drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP Chen Gang
@ 2014-05-17 5:36 ` David Miller
2014-05-17 5:42 ` Chen Gang
2014-05-17 19:55 ` Or Gerlitz
0 siblings, 2 replies; 6+ messages in thread
From: David Miller @ 2014-05-17 5:36 UTC (permalink / raw)
To: gang.chen.5i5j
Cc: roland, sean.hefty, hal.rosenstock, gxt, matanb, ogerlitz, eyalpe,
amirv, sbohrer, linux-rdma, linux-kernel, netdev
From: Chen Gang <gang.chen.5i5j@gmail.com>
Date: Sat, 17 May 2014 13:26:16 +0800
> 'struct irq_affinity_notify' and the related functions are only defined
> when SMP enabled, so at present, mlx4 has to only run under SMP.
>
> The related error (allmodconfig under unicore32):
Making the entire driver depend upon SMP is not the answer,
other Mellanox developers said that a proper fix is pending
so please be patient.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP
2014-05-17 5:36 ` David Miller
@ 2014-05-17 5:42 ` Chen Gang
2014-05-17 19:55 ` Or Gerlitz
1 sibling, 0 replies; 6+ messages in thread
From: Chen Gang @ 2014-05-17 5:42 UTC (permalink / raw)
To: David Miller
Cc: roland, sean.hefty, hal.rosenstock, gxt, matanb, ogerlitz, eyalpe,
amirv, sbohrer, linux-rdma, linux-kernel, netdev
On 05/17/2014 01:36 PM, David Miller wrote:
> From: Chen Gang <gang.chen.5i5j@gmail.com>
> Date: Sat, 17 May 2014 13:26:16 +0800
>
>> 'struct irq_affinity_notify' and the related functions are only defined
>> when SMP enabled, so at present, mlx4 has to only run under SMP.
>>
>> The related error (allmodconfig under unicore32):
>
> Making the entire driver depend upon SMP is not the answer,
> other Mellanox developers said that a proper fix is pending
> so please be patient.
>
OK, thank you for your information. I shall bypass it, and continue.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP
2014-05-17 5:36 ` David Miller
2014-05-17 5:42 ` Chen Gang
@ 2014-05-17 19:55 ` Or Gerlitz
2014-05-18 10:08 ` Chen Gang
2014-05-18 10:08 ` Chen Gang
1 sibling, 2 replies; 6+ messages in thread
From: Or Gerlitz @ 2014-05-17 19:55 UTC (permalink / raw)
To: David Miller
Cc: gang.chen.5i5j, Roland Dreier, Sean Hefty, Hal Rosenstock, gxt,
Matan Barak, Or Gerlitz, Eyal Perry, Amir Vadai, Shawn Bohrer,
linux-rdma, linux-kernel, netdev@vger.kernel.org
On Sat, May 17, 2014 at 8:36 AM, David Miller <davem@davemloft.net> wrote:
>
> From: Chen Gang <gang.chen.5i5j@gmail.com>
> Date: Sat, 17 May 2014 13:26:16 +0800
>
> > 'struct irq_affinity_notify' and the related functions are only defined
> > when SMP enabled, so at present, mlx4 has to only run under SMP.
> >
> > The related error (allmodconfig under unicore32):
>
> Making the entire driver depend upon SMP is not the answer,
Indeed, we would do that just for the relevant portion,
>
> other Mellanox developers said that a proper fix is pending
> so please be patient.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP
2014-05-17 19:55 ` Or Gerlitz
@ 2014-05-18 10:08 ` Chen Gang
2014-05-18 10:08 ` Chen Gang
1 sibling, 0 replies; 6+ messages in thread
From: Chen Gang @ 2014-05-18 10:08 UTC (permalink / raw)
To: Or Gerlitz
Cc: David Miller, Roland Dreier, Sean Hefty, Hal Rosenstock, gxt,
Matan Barak, Or Gerlitz, Eyal Perry, Amir Vadai, Shawn Bohrer,
linux-rdma, linux-kernel, netdev@vger.kernel.org
On 05/18/2014 03:55 AM, Or Gerlitz wrote:
> On Sat, May 17, 2014 at 8:36 AM, David Miller <davem@davemloft.net> wrote:
>>
>> From: Chen Gang <gang.chen.5i5j@gmail.com>
>> Date: Sat, 17 May 2014 13:26:16 +0800
>>
>>> 'struct irq_affinity_notify' and the related functions are only defined
>>> when SMP enabled, so at present, mlx4 has to only run under SMP.
>>>
>>> The related error (allmodconfig under unicore32):
>>
>> Making the entire driver depend upon SMP is not the answer,
>
>
> Indeed, we would do that just for the relevant portion,
>
Thank you for your work.
And next, when I meet the case like this again, instead of sending
patch, I shall send suggestion message to the related members/experts.
Thanks.
--
Chen Gang
Open, share and attitude like air, water and life which God blessed
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP
2014-05-17 19:55 ` Or Gerlitz
2014-05-18 10:08 ` Chen Gang
@ 2014-05-18 10:08 ` Chen Gang
1 sibling, 0 replies; 6+ messages in thread
From: Chen Gang @ 2014-05-18 10:08 UTC (permalink / raw)
To: Or Gerlitz
Cc: David Miller, Roland Dreier, Sean Hefty, Hal Rosenstock, gxt,
Matan Barak, Or Gerlitz, Eyal Perry, Amir Vadai, Shawn Bohrer,
linux-rdma, linux-kernel, netdev@vger.kernel.org
On 05/18/2014 03:55 AM, Or Gerlitz wrote:
> On Sat, May 17, 2014 at 8:36 AM, David Miller <davem@davemloft.net> wrote:
>>
>> From: Chen Gang <gang.chen.5i5j@gmail.com>
>> Date: Sat, 17 May 2014 13:26:16 +0800
>>
>>> 'struct irq_affinity_notify' and the related functions are only defined
>>> when SMP enabled, so at present, mlx4 has to only run under SMP.
>>>
>>> The related error (allmodconfig under unicore32):
>>
>> Making the entire driver depend upon SMP is not the answer,
>
>
> Indeed, we would do that just for the relevant portion,
>
Thank you for your work.
And next, when I meet the case like this again, instead of sending
patch, I shall send suggestion message to the related members/experts.
Thanks.
--
Chen Gang
Open, share and attitude like air, water and life which God blessed
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-18 10:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-17 5:26 [PATCH] drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP Chen Gang
2014-05-17 5:36 ` David Miller
2014-05-17 5:42 ` Chen Gang
2014-05-17 19:55 ` Or Gerlitz
2014-05-18 10:08 ` Chen Gang
2014-05-18 10:08 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox