From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030338AbaEQRVM (ORCPT ); Sat, 17 May 2014 13:21:12 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:59738 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030196AbaEQRVL (ORCPT ); Sat, 17 May 2014 13:21:11 -0400 Message-ID: <53779A7F.8020007@iki.fi> Date: Sat, 17 May 2014 20:21:03 +0300 From: Antti Palosaari User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Martin Kepplinger , gregkh@linuxfoundation.org, Devin Heitmueller CC: m.chehab@samsung.com, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2] staging: media: as102: replace custom dprintk() with dev_dbg() References: <53776B57.5050504@iki.fi> <1400342738-32652-1-git-send-email-martink@posteo.de> In-Reply-To: <1400342738-32652-1-git-send-email-martink@posteo.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 85.23.164.239 X-SA-Exim-Mail-From: crope@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/17/2014 07:05 PM, Martin Kepplinger wrote: > don't reinvent dev_dbg(). remove dprintk() in as102_drv.c. > use the common kernel coding style. > > Signed-off-by: Martin Kepplinger Reviewed-by: Antti Palosaari > --- > this applies to next-20140516. any more suggestions? > more cleanup can be done when dprintk() is completely gone. Do you have the device? I am a bit reluctant patching that driver without any testing as it has happened too many times something has gone totally broken. IIRC Devin said it is in staging because of style issues and nothing more. Is that correct? regards Antti -- http://palosaari.fi/