From: David Howells <dhowells@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: Davi Arnaut <davi.arnaut@gmail.com>,
akpm@osdl.org, vsu@altlinux.ru, alan@lxorguk.ukuu.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] strndup_user (v3), convert (keyctl)
Date: Mon, 20 Feb 2006 10:38:16 +0000 [thread overview]
Message-ID: <5378.1140431896@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <4993.1140431092@warthog.cambridge.redhat.com>
David Howells <dhowells@redhat.com> wrote:
> > I think you should just tell Andrew to drop
> > keys-deal-properly-with-strnlen_user.patch
> > in favor of mine... :-)
>
> No... you've taken out all the checks on lengths on NUL-terminated strings.
I take that back... strndup not strdup.
However, the check on the length of the type is wrong with your patch (and in
the unpatched kernel). Can you pull in that bit from my patch?
David
next prev parent reply other threads:[~2006-02-20 10:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-18 14:36 [PATCH 2/2] strndup_user (v3), convert (keyctl) Davi Arnaut
2006-02-18 16:44 ` David Howells
2006-02-18 19:11 ` Davi Arnaut
2006-02-20 10:24 ` David Howells
2006-02-20 10:38 ` David Howells [this message]
2006-02-20 20:09 ` Davi Arnaut
2006-03-01 14:06 ` David Howells
2006-03-01 15:16 ` Davi Arnaut
2006-03-01 20:50 ` Andrew Morton
2006-03-01 21:04 ` Davi Arnaut
2006-03-01 22:06 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5378.1140431896@warthog.cambridge.redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davi.arnaut@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vsu@altlinux.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox