Re: [PATCH v3 1/7] pinctrl: berlin: add the core pinctrl driver for Marvell Berlin SoCs

Linus Walleij
2014-05-22T21:59:41Z

On Sat, May 17, 2014 at 12:08 PM, Sebastian Hesselbarth
<sebastian.hesselbarth@gmail.com> wrote:

> thinking of your request to make "function"/"groups" standard
> properties, I guess you also had some corresponding helpers in
> mind.

Yeah :-)

> Looking at the map and free functions here, I can see no Berlin
> specific code at all. One option would be to make those functions
> a standard callback for .dt_node_to_map and .dt_free_map, i.e.
> pinctrl_utils_function_group_dt_node_to_map.
>
> IMHO, the more flexible option would be to rather have
>
> of_pinctrl_utils_read_function(node, &function_name, &ngroups)
> and
> of_pinctrl_for_each_function_group(node, group_name)
> swallowing the property names and reuse it like below.
>
> The simple option would be to just remove the marvell, prefix
> now and have a closer look at other pinctrl drivers to see what
> will be required, of course.
>
> Do you have any preference?

I would prefer a two-stage rocket, one removing the Marvell prefix
and another bringing the helpers into pinctrl-utils.

Do I hear a patch coming? :-)

Yours,
Linus Walleij