From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754146AbaESKvu (ORCPT ); Mon, 19 May 2014 06:51:50 -0400 Received: from mail-ee0-f45.google.com ([74.125.83.45]:59671 "EHLO mail-ee0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753514AbaESKvq (ORCPT ); Mon, 19 May 2014 06:51:46 -0400 Message-ID: <5379E238.1080803@gmail.com> Date: Mon, 19 May 2014 12:51:36 +0200 From: Tomasz Figa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Tarek Dakhran , linux-kernel@vger.kernel.org CC: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Rob Landley , Kukjin Kim , Russell King , Ben Dooks , Tomasz Figa , Mike Turquette , Vyacheslav Tyrtov , Thomas Abraham , Kyungmin Park , Heiko Stuebner , Romain Naour , Chander Kashyap , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Tarek Dakhran Subject: Re: [PATCH v9 0/3] Exynos 5410 support References: <1400470640-30611-1-git-send-email-t.dakhran@samsung.com> In-Reply-To: <1400470640-30611-1-git-send-email-t.dakhran@samsung.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tarek, On 19.05.2014 05:37, Tarek Dakhran wrote: > The series of patches represent support of Exynos 5410 SoC > > The Exynos 5410 is the first Samsung SoC based on big.LITTLE architecture > > Patches add new platform description, support of clock controller and device > tree for Exynos 5410. > > Has been build on Samsung Linux Kernel > (branch: for-next, commit: ccf5511 ARM: EXYNOS: Add MCPM call-back functions) This doesn't look like an up-to-date tip of that branch. There was a lot of changes merged 2 days ago, especially from samsung-clk tree and your patches won't apply and/or compile (at least patch 2/3). Are you sure you didn't have a git fetch error? Moreover I can still see the dts using full-path syntax, instead of reference-based one and also no soc node, as I pointed in v8. [1] [1] https://lkml.org/lkml/2014/4/26/59 Another thing is that I still see a custom fixed clock binding being used for oscclk in the clock driver, while I believe I pointed in some of the previous versions that generic fixed clock should be used. Best regards, Tomasz