From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754728AbaESOTD (ORCPT ); Mon, 19 May 2014 10:19:03 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:43696 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752984AbaESOTA (ORCPT ); Mon, 19 May 2014 10:19:00 -0400 Message-ID: <537A12DF.2030101@linaro.org> Date: Mon, 19 May 2014 16:19:11 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Xiubo Li , tglx@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 1/2] clocksource: fix type confusion for clocksource_mmio_readX_Y References: <1398219120-23029-1-git-send-email-Li.Xiubo@freescale.com> In-Reply-To: <1398219120-23029-1-git-send-email-Li.Xiubo@freescale.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/23/2014 04:11 AM, Xiubo Li wrote: > The types' definations are: > o cycle_t -> u64 > o readl_relaxed -> u32 > o readw_relaxed -> u16 > > So let clocksource_mmio_readX_Ys return a cast to cycle_t, though > this maybe look reduntant sometimes, it make sense and they will be > more readable and less confusion... > > This patch clarifies the functions type and fix it. > > Signed-off-by: Xiubo Li > Cc: Daniel Lezcano > --- Applied to my tree for 3.16 Thanks -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog