From: Randy Dunlap <rdunlap@infradead.org>
To: Diego Viola <diego.viola@gmail.com>,
Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Mateusz Guzik <mguzik@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
Ingo Molnar <mingo@kernel.org>, Mel Gorman <mgorman@suse.de>,
Kay Sievers <kay@vrfy.org>
Subject: Re: [RFC PATCH] cmdline: Hide "debug" from /proc/cmdline
Date: Mon, 19 May 2014 07:40:56 -0700 [thread overview]
Message-ID: <537A17F8.6050109@infradead.org> (raw)
In-Reply-To: <CA+ToGPF_GnnNhSUZjmbyu=5Nk=i2cTkoWPiykaO4EKJSfvNh-w@mail.gmail.com>
On 05/19/2014 01:11 AM, Diego Viola wrote:
> I mean "e.g.:" is wrong, it should be e.g. or e.g.,
I don't see that in the wikipedia page. Are you basing that on
"in this usage it is sometimes followed by a comma, depending on style."?
I don't see a problem with the colon, since the quoted phrase has some
conditions in it, like "sometimes" and "depending". Colons are often used
to delimit a list or an example, but I'll leave it up to Rusty.
> Sorry to be too nitpicky or annoying about this.
>
> Diego
>
> On Mon, May 19, 2014 at 5:06 AM, Diego Viola <diego.viola@gmail.com> wrote:
>> e.g. should be written as e.g. or e.g.,
>>
>> There's no need to add another colon ":" after the one that it's already there.
>>
>> See, http://en.wikipedia.org/wiki/E.g.#e.g.
>>
>> Please fix that.
>>
>> Thanks,
>>
>> Diego
>>
>> On Mon, May 5, 2014 at 9:57 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
>>> Randy Dunlap <rdunlap@infradead.org> writes:
>>>> All looks good to me except for 2 instances of "eg" which should be
>>>> "e.g." (just above and about 4 paragraphs below here).
>>>
>>> Thanks, fixed:
>>>
>>> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
>>> index 56a4c2d0c741..a42b9dd6b46b 100644
>>> --- a/Documentation/kernel-parameters.txt
>>> +++ b/Documentation/kernel-parameters.txt
>>> @@ -14,7 +14,7 @@ environment, others are passed as command line arguments to init.
>>> Everything after "--" is passed as an argument to init.
>>>
>>> Module parameters can be specified in two ways: via the kernel command
>>> -line with a module name prefix, or via modprobe, eg:
>>> +line with a module name prefix, or via modprobe, e.g.:
>>>
>>> (kernel command line) usbcore.blinkenlights=1
>>> (modprobe command line) modprobe usbcore blinkenlights=1
>>> @@ -30,7 +30,7 @@ Hyphens (dashes) and underscores are equivalent in parameter names, so
>>> can also be entered as
>>> log-buf-len=1M print_fatal_signals=1
>>>
>>> -Double-quotes can be used to protect spaces in values, eg:
>>> +Double-quotes can be used to protect spaces in values, e.g.:
>>> param="spaces in here"
>>>
>>> This document may not be entirely up to date and comprehensive. The command
>>> --
--
~Randy
next prev parent reply other threads:[~2014-05-19 14:41 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 18:42 [RFC PATCH] cmdline: Hide "debug" from /proc/cmdline Steven Rostedt
2014-04-02 18:57 ` Linus Torvalds
2014-04-02 19:04 ` Andrew Morton
2014-04-02 19:05 ` Borislav Petkov
2014-04-02 19:08 ` Randy Dunlap
2014-04-02 19:50 ` Thomas Gleixner
2014-04-02 20:05 ` Richard Weinberger
2014-04-02 20:43 ` Thomas Gleixner
2014-04-02 22:18 ` Greg KH
2014-04-02 19:08 ` Borislav Petkov
2014-04-02 19:33 ` Steven Rostedt
2014-04-02 22:12 ` Mateusz Guzik
2014-04-02 22:30 ` David Daney
2014-04-02 22:37 ` Greg KH
2014-04-02 23:13 ` Linus Torvalds
2014-04-02 23:23 ` Jiri Kosina
2014-04-02 23:28 ` Andrew Morton
2014-04-02 23:42 ` Linus Torvalds
2014-04-02 23:47 ` Jiri Kosina
2014-04-02 23:52 ` Linus Torvalds
2014-04-02 23:57 ` Jiri Kosina
2014-04-03 1:38 ` Steven Rostedt
2014-04-03 1:47 ` Linus Torvalds
2014-04-03 9:03 ` Borislav Petkov
2014-04-03 10:43 ` Joerg Roedel
2014-04-03 17:05 ` Theodore Ts'o
2014-04-03 17:09 ` H. Peter Anvin
2014-04-03 17:18 ` Theodore Ts'o
2014-04-03 19:19 ` H. Peter Anvin
2014-04-04 18:21 ` Andy Lutomirski
2014-04-04 18:32 ` Linus Torvalds
2014-04-04 18:57 ` Andy Lutomirski
2014-04-04 19:09 ` Linus Torvalds
2014-04-04 21:17 ` John Stoffel
2014-04-04 23:17 ` Greg Kroah-Hartman
2014-04-05 14:37 ` John Stoffel
2014-04-05 23:23 ` Theodore Ts'o
2014-04-04 18:42 ` Linus Torvalds
2014-04-04 18:51 ` Andrew Morton
2014-04-04 18:57 ` Linus Torvalds
2014-04-06 20:49 ` David Timothy Strauss
2014-05-06 9:38 ` Felipe Contreras
2014-04-04 19:44 ` Steven Rostedt
2014-04-04 20:17 ` Theodore Ts'o
2014-04-04 22:45 ` Alexei Starovoitov
2014-04-04 22:48 ` Linus Torvalds
2014-04-04 19:00 ` Andy Lutomirski
2014-04-03 11:23 ` Borislav Petkov
2014-04-03 11:38 ` Ingo Molnar
2014-04-15 7:26 ` Borislav Petkov
2014-04-03 10:34 ` Måns Rullgård
2014-04-03 11:03 ` Borislav Petkov
2014-04-06 17:19 ` One Thousand Gnomes
2014-05-06 9:47 ` Felipe Contreras
2014-04-02 23:47 ` Joe Perches
2014-04-02 23:31 ` Linus Torvalds
2014-04-03 11:25 ` Måns Rullgård
2014-04-03 15:17 ` Tim Bird
2014-04-03 18:06 ` Greg Kroah-Hartman
2014-05-06 9:35 ` Felipe Contreras
2014-04-07 4:54 ` Rusty Russell
2014-05-02 22:34 ` Andrew Morton
2014-05-05 2:17 ` Rusty Russell
2014-05-05 13:15 ` Randy Dunlap
2014-05-06 0:57 ` Rusty Russell
2014-05-19 8:06 ` Diego Viola
2014-05-19 8:11 ` Diego Viola
2014-05-19 14:40 ` Randy Dunlap [this message]
2014-05-20 1:26 ` Rusty Russell
2014-05-20 6:26 ` Diego Viola
2014-05-21 1:52 ` Rusty Russell
2014-04-03 0:49 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2014-04-23 15:15 Borislav Petkov
2014-04-23 20:44 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537A17F8.6050109@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=diego.viola@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mguzik@redhat.com \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox