From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964796AbaESQxz (ORCPT ); Mon, 19 May 2014 12:53:55 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:49867 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755034AbaESQxw (ORCPT ); Mon, 19 May 2014 12:53:52 -0400 Message-ID: <537A36F9.40004@ti.com> Date: Mon, 19 May 2014 19:53:13 +0300 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Sekhar Nori , , CC: , , , , , , , , Subject: Re: [PATCH v3 00/13] ARM/DT: edma: IP configuration from hardware and cleanups References: <1400242640-9902-1-git-send-email-peter.ujfalusi@ti.com> <537A01F2.2090107@ti.com> In-Reply-To: <537A01F2.2090107@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/19/2014 04:06 PM, Sekhar Nori wrote: > On Friday 16 May 2014 05:47 PM, Peter Ujfalusi wrote: >> Hi, >> >> Changes since v2: >> - Comments from Sekhar and Arnd has been addressed best as I could. >> - Use the CCCFG information in all cases instead of pdata provided information >> - To achieve this I needed to do a bit more cleanup in this series >> - In the documentation patch, retrain the old properties for reference >> - Cleanups in the old davinci board files and removing edma_soc_info members >> >> Changes sicne v1: >> - added missing patch to remove the memset from edma_of_parse_dt() >> >> We are requesting redundant information via DT for the driver since the very same >> data is available in the HW: by reading and decoding the content of CCCFG >> register we can get: >> Number of channels: NUM_DMACH >> Number of regions: NUM_REGN >> Number of slots (PaRAM sets): NUM_PAENTRY >> Number of TC/EQ: NUM_EVQUE >> >> So these does not need to be provided by the DT binding. >> >> The driver will no longer look for these properties from DT and they can be >> removed from the binding documentation and from the dtsi files as well. >> The change will not introduce regression when new kernel is booted using older >> DTB (since we just ignore the mentioned properties). > > Applied all patches and pushed to branch v3.16/edma of: > > git://git.kernel.org/pub/scm/linux/kernel/git/nsekhar/linux-davinci.git > > Since the patches did not apply cleanly, please verify. I tested on > DA850 EVM using MMC/SD as EDMA user. The patches in this series looks OK in your branch. However I can not find the following commits in there, which I have in linux-next: c689a7b79c28 Merge remote-tracking branch 'slave-dma/next' cdae05a0f0f7 dmaengine: edma: Make reading the position of active channels work cf7eb979116c ARM: common: edma: Fix xbar mapping 232b223d8281 dmaengine: edma: Set DMA_CYCLIC capability flag 7cf2af90cd51 arm: common: edma: Save the number of event queues/TCs They might come via different route... > > I will wait to get acks from DT maintainers before sending to ARM-SoC. > > Thanks, > Sekhar > Thanks, Péter