public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Gioh Kim <gioh.kim@lge.com>
To: '김준수' <iamjoonsoo.kim@lge.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Michal Nazarewicz" <mina86@mina86.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	"Heesub Shin" <heesub.shin@samsung.com>,
	"Mel Gorman" <mgorman@suse.de>,
	"Johannes Weiner" <hannes@cmpxchg.org>
Cc: 이건호 <gunho.lee@lge.com>
Subject: [RFC PATCH] arm: dma-mapping: fallback allocation for cma failure
Date: Tue, 20 May 2014 14:57:47 +0900	[thread overview]
Message-ID: <537AEEDB.2000001@lge.com> (raw)


Thanks for your advise, Michal Nazarewicz.

Having discuss with Joonsoo, I'm adding fallback allocation after __alloc_from_contiguous().
The fallback allocation works if CMA kernel options is turned on but CMA size is zero.

--------------------- 8< ------------------------

>From 05e389683ddd07027e8acb61c25f3284f762300e Mon Sep 17 00:00:00 2001
From: Gioh Kim <gioh.kim@lge.com>
Date: Tue, 20 May 2014 14:16:20 +0900
Subject: [PATCH] arm: dma-mapping: fallback allocation for cma failure

If CMA is turned on and CMA size is set to zero, kernel should
behave as if CMA was not enabled at compile time.
Fallback allocation is added for CMA allocation failure.

Signed-off-by: Gioh Kim <gioh.kim@lge.com>
Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
---
 arch/arm/mm/dma-mapping.c |   11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index 18e98df..2a6c883 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -379,7 +379,7 @@ static int __init atomic_pool_init(void)
        unsigned long *bitmap;
        struct page *page;
        struct page **pages;
-       void *ptr;
+       void *ptr = NULL;
        int bitmap_size = BITS_TO_LONGS(nr_pages) * sizeof(long);

        bitmap = kzalloc(bitmap_size, GFP_KERNEL);
@@ -393,9 +393,10 @@ static int __init atomic_pool_init(void)
        if (IS_ENABLED(CONFIG_DMA_CMA))
                ptr = __alloc_from_contiguous(NULL, pool->size, prot, &page,
                                              atomic_pool_init);
-       else
+       if (!ptr)
                ptr = __alloc_remap_buffer(NULL, pool->size, gfp, prot, &page,
                                           atomic_pool_init);
+
        if (ptr) {
                int i;

@@ -703,8 +704,12 @@ static void *__dma_alloc(struct device *dev, size_t size, dma_addr_t *handle,
                addr = __alloc_from_pool(size, &page);
        else if (!IS_ENABLED(CONFIG_DMA_CMA))
                addr = __alloc_remap_buffer(dev, size, gfp, prot, &page, caller);
-       else
+       else {
                addr = __alloc_from_contiguous(dev, size, prot, &page, caller);
+               if (!addr)
+                       addr = __alloc_remap_buffer(dev, size, gfp, prot,
+                                                   &page, caller);
+       }

        if (addr)
                *handle = pfn_to_dma(dev, page_to_pfn(page));
--
1.7.9.5

             reply	other threads:[~2014-05-20  5:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20  5:57 Gioh Kim [this message]
2014-05-20  6:52 ` [RFC PATCH] arm: dma-mapping: fallback allocation for cma failure Joonsoo Kim
2014-05-20  7:05   ` Gioh Kim
2014-05-20  8:32     ` Joonsoo Kim
2014-05-20 23:39       ` Gioh Kim
2014-05-20 18:22   ` Michal Nazarewicz
2014-05-21  0:24     ` Gioh Kim
2014-05-21  8:06     ` Gioh Kim
2014-05-21 20:11       ` Michal Nazarewicz
2014-05-22  1:02         ` Gioh Kim
2014-05-22  3:22           ` Michal Nazarewicz
2014-05-22  4:30             ` Gioh Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537AEEDB.2000001@lge.com \
    --to=gioh.kim@lge.com \
    --cc=gunho.lee@lge.com \
    --cc=hannes@cmpxchg.org \
    --cc=heesub.shin@samsung.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mgorman@suse.de \
    --cc=mina86@mina86.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox