From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752792AbaETJx3 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 20 May 2014 05:53:29 -0400
Received: from bear.ext.ti.com ([192.94.94.41]:45128 "EHLO bear.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750706AbaETJx0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 20 May 2014 05:53:26 -0400
Message-ID: <537B3190.9030706@ti.com>
Date: Tue, 20 May 2014 13:42:24 +0300
From: Grygorii Strashko <grygorii.strashko@ti.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Thierry Reding <thierry.reding@gmail.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Grant Likely <grant.likely@linaro.org>, <santosh.shilimkar@ti.com>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Russell King <linux@arm.linux.org.uk>, Rob Herring <robh@kernel.org>,
        Tony Lindgren <tony@atomide.com>
Subject: Re: [RFC PATCH] of/irq: do irq resolution in platform_get_irq_byname()
References: <1400506259-18397-1-git-send-email-grygorii.strashko@ti.com> <20140519125738.GB9466@ulmo>
In-Reply-To: <20140519125738.GB9466@ulmo>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Thierry,

On 05/19/2014 03:57 PM, Thierry Reding wrote:
> On Mon, May 19, 2014 at 04:30:59PM +0300, Grygorii Strashko wrote:
> [...]
>> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> [...]
>>   /**
>> + * of_irq_get_byname - Decode a node's IRQ and return it as a Linux irq number
>> + * @dev: pointer to device tree node
>> + * @name: zero-based index of the irq
> 
> This is a name, not an index.
> 
>> + *
>> + * Returns Linux irq number on success, or -EPROBE_DEFER if the irq domain
>> + * is not yet created, or errorno in case of failure.
> 
> s/errorno/error code/? Also EPROBE_DEFER is also an error code, so I'm
> not sure if it's worth a special case in the description here.

>>From my experience, It's very useful to know that function can return 
EPROBE_DEFER, otherwise, the code need to be traced till place where
EPROBE_DEFER is returned.

> 
>> + *
>> + */
>> +int of_irq_get_byname(struct device_node *dev, const char *name)
>> +{
>> +	const char *name_irq = NULL;
>> +	int index = 0;
>> +
>> +	if (unlikely(!name))
>> +		return -EINVAL;
>> +
>> +	while (!of_property_read_string_index(dev, "interrupt-names",
>> +					      index, &name_irq))
>> +		if (!strcmp(name, name_irq))
>> +			return of_irq_get(dev, index);
> 
> Isn't this missing an index++ somewhere? Otherwise it seems like this
> would loop infinitely if there was no match on the first entry.

Omg. You're right. It was bad day (

Thanks for your review. Patch re-sent.

Regards,
-grygorii