From: "Emilio López" <emilio@elopez.com.ar>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-sunxi@googlegroups.com,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
kevin.z.m.zh@gmail.com, sunny@allwinnertech.com,
shuge@allwinnertech.com, zhuzhenhua@allwinnertech.com,
andriy.shevchenko@intel.com, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [linux-sunxi] [PATCH v7] DMA: sun6i: Add driver for the Allwinner A31 DMA controller
Date: Tue, 20 May 2014 09:40:53 -0300 [thread overview]
Message-ID: <537B4D55.5040804@elopez.com.ar> (raw)
In-Reply-To: <1398349364-10726-2-git-send-email-maxime.ripard@free-electrons.com>
Hi Maxime,
El 24/04/14 11:22, Maxime Ripard escribió:
> The Allwinner A31 has a 16 channels DMA controller that it shares with the
> newer A23. Although sharing some similarities with the DMA controller of the
> older Allwinner SoCs, it's significantly different, I don't expect it to be
> possible to share the driver for these two.
>
> The A31 Controller is able to memory-to-memory or memory-to-device transfers on
> the 16 channels in parallel.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> ---
(snip)
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 5c5863842de9..360a10c71388 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -361,6 +361,14 @@ config FSL_EDMA
> multiplexing capability for DMA request sources(slot).
> This module can be found on Freescale Vybrid and LS-1 SoCs.
>
> +config DMA_SUN6I
> + tristate "Allwinner A31 SoCs DMA support"
> + depends on ARCH_SUNXI
> + select DMA_ENGINE
> + select DMA_VIRTUAL_CHANNELS
I think you also need to select DMA_OF here as you are using
of_dma_controller_register
> + help
> + Support for the DMA engine for Allwinner A31 SoCs.
> +
> config DMA_ENGINE
> bool
Cheers,
Emilio
next prev parent reply other threads:[~2014-05-20 12:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 14:22 [PATCH v7] Add support for the Allwinner A31 DMA Controller Maxime Ripard
2014-04-24 14:22 ` [PATCH v7] DMA: sun6i: Add driver for the Allwinner A31 DMA controller Maxime Ripard
2014-04-30 7:04 ` Vinod Koul
2014-04-30 21:53 ` Maxime Ripard
2014-05-02 16:34 ` Vinod Koul
2014-05-08 3:19 ` Maxime Ripard
2014-05-21 5:29 ` Vinod Koul
2014-05-13 13:42 ` Maxime Ripard
2014-05-21 5:31 ` Vinod Koul
2014-05-21 8:58 ` Maxime Ripard
2014-05-21 11:02 ` Vinod Koul
2014-05-20 12:40 ` Emilio López [this message]
2014-05-20 12:52 ` [linux-sunxi] " Shevchenko, Andriy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537B4D55.5040804@elopez.com.ar \
--to=emilio@elopez.com.ar \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=kevin.z.m.zh@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=shuge@allwinnertech.com \
--cc=sunny@allwinnertech.com \
--cc=vinod.koul@intel.com \
--cc=zhuzhenhua@allwinnertech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox