From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751512AbaEUA4x (ORCPT ); Tue, 20 May 2014 20:56:53 -0400 Received: from mail-pb0-f43.google.com ([209.85.160.43]:59197 "EHLO mail-pb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011AbaEUA4w (ORCPT ); Tue, 20 May 2014 20:56:52 -0400 Message-ID: <537BF9D0.1080101@gmail.com> Date: Wed, 21 May 2014 08:56:48 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Guan Xuetao CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] arch/unicore32/kernel/ksyms.c: remote 2 export symbols to avoid compiling failure References: <537BF961.9070704@gmail.com> In-Reply-To: <537BF961.9070704@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oh, sorry, the subject has a typo issue, need use 'remove' instead of 'remote'. I will send patch v2 for it. On 05/21/2014 08:54 AM, Chen Gang wrote: > 'csum_partial' and 'csum_partial_copy_from_user' have already been > exported in "lib/", so need not export them again, or it will cause > compiling error. > > The related error (with allmodconfig under unicore32): > > LD vmlinux.o > lib/built-in.o:(___ksymtab+csum_partial+0x0): multiple definition of `__ksymtab_csum_partial' > arch/unicore32/kernel/built-in.o:(___ksymtab+csum_partial+0x0): first defined here > lib/built-in.o:(___ksymtab+csum_partial_copy_from_user+0x0): multiple definition of `__ksymtab_csum_partial_copy_from_user' > arch/unicore32/kernel/built-in.o:(___ksymtab+csum_partial_copy_from_user+0x0): first defined here > make: *** [vmlinux] Error 1 > > > Signed-off-by: Chen Gang > --- > arch/unicore32/kernel/ksyms.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/unicore32/kernel/ksyms.c b/arch/unicore32/kernel/ksyms.c > index 63afc7f..bc06140 100644 > --- a/arch/unicore32/kernel/ksyms.c > +++ b/arch/unicore32/kernel/ksyms.c > @@ -30,10 +30,6 @@ EXPORT_SYMBOL(find_next_bit); > EXPORT_SYMBOL(__udelay); > EXPORT_SYMBOL(__const_udelay); > > - /* networking */ > -EXPORT_SYMBOL(csum_partial); > -EXPORT_SYMBOL(csum_partial_copy_from_user); > - > /* string / mem functions */ > EXPORT_SYMBOL(strchr); > EXPORT_SYMBOL(strrchr); > -- Chen Gang Open, share, and attitude like air, water, and life which God blessed