public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] arch/unicore32/kernel/ksyms.c: remove 2 export symbols to avoid compiling failure
@ 2014-05-21  0:57 Chen Gang
  2014-05-21  7:08 ` 管雪涛
  0 siblings, 1 reply; 2+ messages in thread
From: Chen Gang @ 2014-05-21  0:57 UTC (permalink / raw)
  To: Guan Xuetao, linux-kernel@vger.kernel.org

'csum_partial' and 'csum_partial_copy_from_user' have already been
exported in "lib/", so need not export them again, or it will cause
compiling error.

The related error (with allmodconfig under unicore32):

    LD      vmlinux.o
  lib/built-in.o:(___ksymtab+csum_partial+0x0): multiple definition of `__ksymtab_csum_partial'
  arch/unicore32/kernel/built-in.o:(___ksymtab+csum_partial+0x0): first defined here
  lib/built-in.o:(___ksymtab+csum_partial_copy_from_user+0x0): multiple definition of `__ksymtab_csum_partial_copy_from_user'
  arch/unicore32/kernel/built-in.o:(___ksymtab+csum_partial_copy_from_user+0x0): first defined here
  make: *** [vmlinux] Error 1


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/unicore32/kernel/ksyms.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/unicore32/kernel/ksyms.c b/arch/unicore32/kernel/ksyms.c
index 63afc7f..bc06140 100644
--- a/arch/unicore32/kernel/ksyms.c
+++ b/arch/unicore32/kernel/ksyms.c
@@ -30,10 +30,6 @@ EXPORT_SYMBOL(find_next_bit);
 EXPORT_SYMBOL(__udelay);
 EXPORT_SYMBOL(__const_udelay);
 
-	/* networking */
-EXPORT_SYMBOL(csum_partial);
-EXPORT_SYMBOL(csum_partial_copy_from_user);
-
 	/* string / mem functions */
 EXPORT_SYMBOL(strchr);
 EXPORT_SYMBOL(strrchr);
-- 
1.9.2.459.g68773ac

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] arch/unicore32/kernel/ksyms.c: remove 2 export  symbols to avoid compiling failure
  2014-05-21  0:57 [PATCH v2] arch/unicore32/kernel/ksyms.c: remove 2 export symbols to avoid compiling failure Chen Gang
@ 2014-05-21  7:08 ` 管雪涛
  0 siblings, 0 replies; 2+ messages in thread
From: 管雪涛 @ 2014-05-21  7:08 UTC (permalink / raw)
  To: Chen Gang; +Cc: Guan Xuetao, linux-kernel

Thanks, and this is a common error in most architectures.

Acked-by: Xuetao Guan <gxt@mprc.pku.edu.cn>

----- Chen Gang <gang.chen.5i5j@gmail.com> 写道:
> 'csum_partial' and 'csum_partial_copy_from_user' have already been
> exported in "lib/", so need not export them again, or it will cause
> compiling error.
> 
> The related error (with allmodconfig under unicore32):
> 
>     LD      vmlinux.o
>   lib/built-in.o:(___ksymtab+csum_partial+0x0): multiple definition of `__ksymtab_csum_partial'
>   arch/unicore32/kernel/built-in.o:(___ksymtab+csum_partial+0x0): first defined here
>   lib/built-in.o:(___ksymtab+csum_partial_copy_from_user+0x0): multiple definition of `__ksymtab_csum_partial_copy_from_user'
>   arch/unicore32/kernel/built-in.o:(___ksymtab+csum_partial_copy_from_user+0x0): first defined here
>   make: *** [vmlinux] Error 1
> 
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  arch/unicore32/kernel/ksyms.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/unicore32/kernel/ksyms.c b/arch/unicore32/kernel/ksyms.c
> index 63afc7f..bc06140 100644
> --- a/arch/unicore32/kernel/ksyms.c
> +++ b/arch/unicore32/kernel/ksyms.c
> @@ -30,10 +30,6 @@ EXPORT_SYMBOL(find_next_bit);
>  EXPORT_SYMBOL(__udelay);
>  EXPORT_SYMBOL(__const_udelay);
>  
> -	/* networking */
> -EXPORT_SYMBOL(csum_partial);
> -EXPORT_SYMBOL(csum_partial_copy_from_user);
> -
>  	/* string / mem functions */
>  EXPORT_SYMBOL(strchr);
>  EXPORT_SYMBOL(strrchr);
> -- 
> 1.9.2.459.g68773ac


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-21  7:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-21  0:57 [PATCH v2] arch/unicore32/kernel/ksyms.c: remove 2 export symbols to avoid compiling failure Chen Gang
2014-05-21  7:08 ` 管雪涛

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox