* [PATCH] arch: unicore32: kernel: ksyms: remove 'bswapsi2' and 'muldi3' to avoid compiling failure
@ 2014-05-21 1:37 Chen Gang
2014-05-21 7:58 ` 回复: " 管雪涛
0 siblings, 1 reply; 2+ messages in thread
From: Chen Gang @ 2014-05-21 1:37 UTC (permalink / raw)
To: Guan Xuetao, linux-kernel@vger.kernel.org
After check the code, 'bswapsi2' and 'muldi3' are useless for
unicore32, so can remove them to avoid compiling failure.
The related error (with allmodconfig under unicore32):
LD init/built-in.o
arch/unicore32/kernel/built-in.o:(___ksymtab+__muldi3+0x0): undefined reference to `__muldi3'
arch/unicore32/kernel/built-in.o:(___ksymtab+__bswapsi2+0x0): undefined reference to `__bswapsi2'
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
arch/unicore32/kernel/ksyms.c | 2 --
arch/unicore32/kernel/ksyms.h | 2 --
2 files changed, 4 deletions(-)
diff --git a/arch/unicore32/kernel/ksyms.c b/arch/unicore32/kernel/ksyms.c
index bc06140..e78911a 100644
--- a/arch/unicore32/kernel/ksyms.c
+++ b/arch/unicore32/kernel/ksyms.c
@@ -53,9 +53,7 @@ EXPORT_SYMBOL(__ashrdi3);
EXPORT_SYMBOL(__divsi3);
EXPORT_SYMBOL(__lshrdi3);
EXPORT_SYMBOL(__modsi3);
-EXPORT_SYMBOL(__muldi3);
EXPORT_SYMBOL(__ucmpdi2);
EXPORT_SYMBOL(__udivsi3);
EXPORT_SYMBOL(__umodsi3);
-EXPORT_SYMBOL(__bswapsi2);
diff --git a/arch/unicore32/kernel/ksyms.h b/arch/unicore32/kernel/ksyms.h
index 185cdc7..31472ad 100644
--- a/arch/unicore32/kernel/ksyms.h
+++ b/arch/unicore32/kernel/ksyms.h
@@ -8,8 +8,6 @@ extern void __ashrdi3(void);
extern void __divsi3(void);
extern void __lshrdi3(void);
extern void __modsi3(void);
-extern void __muldi3(void);
extern void __ucmpdi2(void);
extern void __udivsi3(void);
extern void __umodsi3(void);
-extern void __bswapsi2(void);
--
1.9.2.459.g68773ac
^ permalink raw reply related [flat|nested] 2+ messages in thread* 回复: [PATCH] arch: unicore32: kernel: ksyms: remove 'bswapsi2' and 'muldi3' to avoid compiling failure
2014-05-21 1:37 [PATCH] arch: unicore32: kernel: ksyms: remove 'bswapsi2' and 'muldi3' to avoid compiling failure Chen Gang
@ 2014-05-21 7:58 ` 管雪涛
0 siblings, 0 replies; 2+ messages in thread
From: 管雪涛 @ 2014-05-21 7:58 UTC (permalink / raw)
To: Chen Gang; +Cc: Guan Xuetao, linux-kernel
Thanks.
For __muldi3, it is no longer used by gcc, so I think that's ok.
For __bswapsi2, maybe it's because I copied it from arm.
Acked-by: Xuetao Guan <gxt@mprc.pku.edu.cn>
----- Chen Gang <gang.chen.5i5j@gmail.com> 写道:
> After check the code, 'bswapsi2' and 'muldi3' are useless for
> unicore32, so can remove them to avoid compiling failure.
>
> The related error (with allmodconfig under unicore32):
>
> LD init/built-in.o
> arch/unicore32/kernel/built-in.o:(___ksymtab+__muldi3+0x0): undefined reference to `__muldi3'
> arch/unicore32/kernel/built-in.o:(___ksymtab+__bswapsi2+0x0): undefined reference to `__bswapsi2'
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> arch/unicore32/kernel/ksyms.c | 2 --
> arch/unicore32/kernel/ksyms.h | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/arch/unicore32/kernel/ksyms.c b/arch/unicore32/kernel/ksyms.c
> index bc06140..e78911a 100644
> --- a/arch/unicore32/kernel/ksyms.c
> +++ b/arch/unicore32/kernel/ksyms.c
> @@ -53,9 +53,7 @@ EXPORT_SYMBOL(__ashrdi3);
> EXPORT_SYMBOL(__divsi3);
> EXPORT_SYMBOL(__lshrdi3);
> EXPORT_SYMBOL(__modsi3);
> -EXPORT_SYMBOL(__muldi3);
> EXPORT_SYMBOL(__ucmpdi2);
> EXPORT_SYMBOL(__udivsi3);
> EXPORT_SYMBOL(__umodsi3);
> -EXPORT_SYMBOL(__bswapsi2);
>
> diff --git a/arch/unicore32/kernel/ksyms.h b/arch/unicore32/kernel/ksyms.h
> index 185cdc7..31472ad 100644
> --- a/arch/unicore32/kernel/ksyms.h
> +++ b/arch/unicore32/kernel/ksyms.h
> @@ -8,8 +8,6 @@ extern void __ashrdi3(void);
> extern void __divsi3(void);
> extern void __lshrdi3(void);
> extern void __modsi3(void);
> -extern void __muldi3(void);
> extern void __ucmpdi2(void);
> extern void __udivsi3(void);
> extern void __umodsi3(void);
> -extern void __bswapsi2(void);
> --
> 1.9.2.459.g68773ac
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-21 7:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-21 1:37 [PATCH] arch: unicore32: kernel: ksyms: remove 'bswapsi2' and 'muldi3' to avoid compiling failure Chen Gang
2014-05-21 7:58 ` 回复: " 管雪涛
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox