public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@st.com>
To: Lee Jones <lee.jones@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <patrice.chotard@st.com>
Cc: <kernel@stlinux.com>
Subject: Re: [PATCH 3/3] ARM: sti: stih41x: Provide a proper header for this DTSI file
Date: Wed, 21 May 2014 10:32:38 +0200	[thread overview]
Message-ID: <537C64A6.4050409@st.com> (raw)
In-Reply-To: <1400660415-14720-3-git-send-email-lee.jones@linaro.org>

Hi Lee,

On 05/21/2014 10:20 AM, Lee Jones wrote:
> Also explicitly include STiH416 Clk bindings instead of relying on
> inheriting them from other DTSI files which we happen to include.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>   arch/arm/boot/dts/stih41x.dtsi | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stih41x.dtsi b/arch/arm/boot/dts/stih41x.dtsi
> index f5b9898..32730e5 100644
> --- a/arch/arm/boot/dts/stih41x.dtsi
> +++ b/arch/arm/boot/dts/stih41x.dtsi
> @@ -1,3 +1,11 @@
> +/*
> + * Copyright (C) 2014 STMicroelectronics Limited.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * publishhed by the Free Software Foundation.
> + */
> +#include "stih416-clock.dtsi"

Nack.
As discussed on IRC, this dtsi file is included by stih415.dtsi.
In this case, we want to include stih415-clocks.dtsi instead.

Regards,
Maxime
>   / {
>   	#address-cells = <1>;
>   	#size-cells = <1>;
>

  reply	other threads:[~2014-05-21  8:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-21  8:20 [PATCH 1/3] ARM: sti: stih416: Add support for B2020 RevE Lee Jones
2014-05-21  8:20 ` [PATCH 2/3] ARM: sti: stih416: Enable board LED " Lee Jones
2014-05-21  8:20 ` [PATCH 3/3] ARM: sti: stih41x: Provide a proper header for this DTSI file Lee Jones
2014-05-21  8:32   ` Maxime Coquelin [this message]
2014-05-21  9:12     ` Lee Jones
  -- strict thread matches above, loose matches on Subject: below --
2014-03-11 10:22 [PATCH 1/3] ARM: DT: STi: Add support to B2020 revision E board Lee Jones
2014-03-11 10:22 ` [PATCH 3/3] ARM: STi: stih41x: Provide a proper header for this DTSI file Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537C64A6.4050409@st.com \
    --to=maxime.coquelin@st.com \
    --cc=kernel@stlinux.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrice.chotard@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox