From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Victor Lambret <victor.lambret.ext@parrot.com>,
Pawel Osciak <pawel@osciak.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] videobuf2-core: remove duplicated code
Date: Wed, 21 May 2014 12:36:28 +0200 [thread overview]
Message-ID: <537C81AC.60901@samsung.com> (raw)
In-Reply-To: <1400665723-21695-1-git-send-email-victor.lambret.ext@parrot.com>
Hello,
On 2014-05-21 11:48, Victor Lambret wrote:
> Remove duplicated test of buffer presence at streamon
>
> Signed-off-by: Victor Lambret <victor.lambret.ext@parrot.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
> index f9059bb..b731b66 100644
> --- a/drivers/media/v4l2-core/videobuf2-core.c
> +++ b/drivers/media/v4l2-core/videobuf2-core.c
> @@ -2067,10 +2067,6 @@ static int vb2_internal_streamon(struct vb2_queue *q, enum v4l2_buf_type type)
> return -EINVAL;
> }
>
> - if (!q->num_buffers) {
> - dprintk(1, "streamon: no buffers have been allocated\n");
> - return -EINVAL;
> - }
> if (q->num_buffers < q->min_buffers_needed) {
> dprintk(1, "streamon: need at least %u allocated buffers\n",
> q->min_buffers_needed);
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
prev parent reply other threads:[~2014-05-21 10:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 9:48 [PATCH] videobuf2-core: remove duplicated code Victor Lambret
2014-05-21 10:36 ` Marek Szyprowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537C81AC.60901@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=pawel@osciak.com \
--cc=victor.lambret.ext@parrot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox