* [PATCH] 9P: fix return value in v9fs_fid_xattr_set [not found] <20140521065219.GA15962@u-barrelet> @ 2014-05-21 8:02 ` Dominique Martinet 2014-05-21 13:14 ` Alin Dobre 0 siblings, 1 reply; 2+ messages in thread From: Dominique Martinet @ 2014-05-21 8:02 UTC (permalink / raw) To: v9fs-developer, Eric Van Hensbergen Cc: Eric W. Biederman, linux-fsdevel, linux-kernel, Alin Dobre, Ron Minnich, Latchesar Ionkov, Dominique Martinet v9fs_fid_xattr_set is supposed to return 0 on success. This corrects the behaviour introduced in commit bdd5c28dcb8330b9074404cc92a0b83aae5606a "9p: fix return value in case in v9fs_fid_xattr_set()" (The function returns a negative error on error, as expected) Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr> --- fs/9p/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/9p/xattr.c b/fs/9p/xattr.c index 04133a1..f95e01e 100644 --- a/fs/9p/xattr.c +++ b/fs/9p/xattr.c @@ -156,7 +156,7 @@ int v9fs_fid_xattr_set(struct p9_fid *fid, const char *name, offset += write_count; value_len -= write_count; } - retval = offset; + retval = 0; err: p9_client_clunk(fid); return retval; -- 1.9.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] 9P: fix return value in v9fs_fid_xattr_set 2014-05-21 8:02 ` [PATCH] 9P: fix return value in v9fs_fid_xattr_set Dominique Martinet @ 2014-05-21 13:14 ` Alin Dobre 0 siblings, 0 replies; 2+ messages in thread From: Alin Dobre @ 2014-05-21 13:14 UTC (permalink / raw) To: Dominique Martinet, v9fs-developer, Eric Van Hensbergen Cc: Eric W. Biederman, linux-fsdevel, linux-kernel, Ron Minnich, Latchesar Ionkov On 21/05/14 09:02, Dominique Martinet wrote: > v9fs_fid_xattr_set is supposed to return 0 on success. > > This corrects the behaviour introduced in commit > bdd5c28dcb8330b9074404cc92a0b83aae5606a > "9p: fix return value in case in v9fs_fid_xattr_set()" > > (The function returns a negative error on error, as expected) > > Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr> > --- > fs/9p/xattr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/9p/xattr.c b/fs/9p/xattr.c > index 04133a1..f95e01e 100644 > --- a/fs/9p/xattr.c > +++ b/fs/9p/xattr.c > @@ -156,7 +156,7 @@ int v9fs_fid_xattr_set(struct p9_fid *fid, const char *name, > offset += write_count; > value_len -= write_count; > } > - retval = offset; > + retval = 0; > err: > p9_client_clunk(fid); > return retval; > This patch seems to be fixing the problem, thanks! ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-21 13:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140521065219.GA15962@u-barrelet>
2014-05-21 8:02 ` [PATCH] 9P: fix return value in v9fs_fid_xattr_set Dominique Martinet
2014-05-21 13:14 ` Alin Dobre
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox