From: Sudeep Holla <sudeep.holla@arm.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arvind Chauhan <Arvind.Chauhan@arm.com>,
"inderpal.s@samsung.com" <inderpal.s@samsung.com>,
"nm@ti.com" <nm@ti.com>,
"chander.kashyap@linaro.org" <chander.kashyap@linaro.org>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"len.brown@intel.com" <len.brown@intel.com>
Subject: Re: [PATCH V2 5/7] cpufreq: imx6q: don't initialize opp table
Date: Wed, 21 May 2014 15:31:58 +0100 [thread overview]
Message-ID: <537CB8DE.2050001@arm.com> (raw)
In-Reply-To: <20140521141622.GB27211@dragon>
On 21/05/14 15:16, Shawn Guo wrote:
> On Wed, May 21, 2014 at 03:07:36PM +0100, Sudeep Holla wrote:
>>> @@ -376,7 +356,7 @@ static void __init imx6q_init_late(void)
>>> imx6q_cpuidle_init();
>>>
>>> if (IS_ENABLED(CONFIG_ARM_IMX6Q_CPUFREQ)) {
>>> - imx6q_opp_init();
>>> + imx6q_opp_check_speed_grading();
>>
>> [Query] Not exactly related to this patch, but asking it here to get clarified.
>>
>> This OPP limiting is done as part of late initcall and if the cpufreq driver is
>> built in the kernel, there will be a small window where the OPPs not supported
>> are still enabled ? Will that not be an issue if say performance governor is
>> selected by default.
>
> Even if cpufreq driver is built in the kernel, it won't be probed until
> platform_device_register(&imx6q_cpufreq_pdev) is called. And we make
> this call only after the OPP limiting.
>
Ah right, I missed that. Thanks for clarifying.
Regards,
Sudeep
next prev parent reply other threads:[~2014-05-21 14:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 11:09 [PATCH V2 0/7] CPUFreq: Initialize CPU's OPP tables from CPU core Viresh Kumar
2014-05-21 11:09 ` [PATCH V2 1/7] opp: remove -ENOSYS from dummy implementation of of_init_opp_table() Viresh Kumar
2014-05-21 13:16 ` Sudeep Holla
2014-05-21 13:27 ` Viresh Kumar
2014-05-21 11:10 ` [PATCH V2 2/7] opp: handle of_node_{get|put}() inside of_init_opp_table() Viresh Kumar
2014-05-21 11:10 ` [PATCH V2 3/7] driver/core: cpu: initialize opp table Viresh Kumar
2014-05-21 13:45 ` Sudeep Holla
2014-05-21 14:01 ` Viresh Kumar
2014-05-21 14:42 ` Sudeep Holla
2014-05-21 14:59 ` Viresh Kumar
2014-05-21 17:26 ` Sudeep Holla
2014-05-22 4:11 ` Viresh Kumar
2014-05-21 11:10 ` [PATCH V2 4/7] cpufreq: arm_big_little: don't " Viresh Kumar
2014-05-21 11:35 ` Inderpal Singh
2014-05-21 13:29 ` Viresh Kumar
2014-05-21 11:10 ` [PATCH V2 5/7] cpufreq: imx6q: " Viresh Kumar
2014-05-21 14:07 ` Sudeep Holla
2014-05-21 14:16 ` Shawn Guo
2014-05-21 14:31 ` Sudeep Holla [this message]
2014-05-21 11:10 ` [PATCH V2 6/7] cpufreq: cpufreq-cpu0: " Viresh Kumar
2014-05-21 11:10 ` [PATCH V2 7/7] cpufreq: exynos5440: " Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537CB8DE.2050001@arm.com \
--to=sudeep.holla@arm.com \
--cc=Arvind.Chauhan@arm.com \
--cc=chander.kashyap@linaro.org \
--cc=inderpal.s@samsung.com \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=shawn.guo@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox