* [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame
@ 2014-05-10 12:02 Jay Aurabind
2014-05-20 15:20 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Jay Aurabind @ 2014-05-10 12:02 UTC (permalink / raw)
To: Linus Walleij, Samuel Ortiz, Lee Jones
Cc: linux-arm-kernel, linux-kernel, Trivial Monkey
[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]
From 95f6ac368dbe352af0dfa2097b7d58b416447be5 Mon Sep 17 00:00:00 2001
From: Aurabindo J <mail@aurabindo.in>
Date: Sat, 10 May 2014 15:16:58 +0530
Subject: [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame
On systems with CONFIG_FRAME_WARN=1024, compiler warns the allocation of
an object of struct device on stack. Make the allocation dynamically to
fix the warning.
drivers/mfd/abx500-core.c: In function ‘abx500_dump_all_banks’:
drivers/mfd/abx500-core.c:167:1: warning: the frame size of 1032 bytes
is larger than 1024 bytes [-Wframe-larger-than=]
Signed-off-by: Aurabindo J <mail@aurabindo.in>
---
drivers/mfd/abx500-core.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/abx500-core.c b/drivers/mfd/abx500-core.c
index f3a15aa..87d80c3 100644
--- a/drivers/mfd/abx500-core.c
+++ b/drivers/mfd/abx500-core.c
@@ -154,16 +154,19 @@ EXPORT_SYMBOL(abx500_startup_irq_enabled);
void abx500_dump_all_banks(void)
{
struct abx500_ops *ops;
- struct device dummy_child = {NULL};
+ struct device *dummy_child;
struct abx500_device_entry *dev_entry;
+ dummy_child = kzalloc(sizeof(struct device), GFP_KERNEL);
+
list_for_each_entry(dev_entry, &abx500_list, list) {
- dummy_child.parent = dev_entry->dev;
+ dummy_child->parent = dev_entry->dev;
ops = &dev_entry->ops;
if ((ops != NULL) && (ops->dump_all_banks != NULL))
- ops->dump_all_banks(&dummy_child);
+ ops->dump_all_banks(dummy_child);
}
+ kfree(dummy_child);
}
EXPORT_SYMBOL(abx500_dump_all_banks);
--
1.9.1
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 278 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame
2014-05-10 12:02 [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame Jay Aurabind
@ 2014-05-20 15:20 ` Lee Jones
2014-05-21 6:15 ` [PATCH V2] " Jay Aurabind
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2014-05-20 15:20 UTC (permalink / raw)
To: Jay Aurabind
Cc: Linus Walleij, Samuel Ortiz, linux-arm-kernel, linux-kernel,
Trivial Monkey
> From 95f6ac368dbe352af0dfa2097b7d58b416447be5 Mon Sep 17 00:00:00 2001
> From: Aurabindo J <mail@aurabindo.in>
> Date: Sat, 10 May 2014 15:16:58 +0530
> Subject: [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame
>
> On systems with CONFIG_FRAME_WARN=1024, compiler warns the allocation of
> an object of struct device on stack. Make the allocation dynamically to
> fix the warning.
>
> drivers/mfd/abx500-core.c: In function ‘abx500_dump_all_banks’:
> drivers/mfd/abx500-core.c:167:1: warning: the frame size of 1032 bytes
> is larger than 1024 bytes [-Wframe-larger-than=]
>
> Signed-off-by: Aurabindo J <mail@aurabindo.in>
> ---
> drivers/mfd/abx500-core.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Looks good to me. I'll apply it until Linus complains.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] mfd: abx500-core: Fix compiler warning larger stack frame
2014-05-20 15:20 ` Lee Jones
@ 2014-05-21 6:15 ` Jay Aurabind
2014-05-21 9:17 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Jay Aurabind @ 2014-05-21 6:15 UTC (permalink / raw)
To: Lee Jones
Cc: Linus Walleij, Samuel Ortiz, linux-arm-kernel, linux-kernel,
kbuild test robot, Lee Jones
[-- Attachment #1: Type: text/plain, Size: 1983 bytes --]
H1,
Change from V1 -> V2: Fix a potential null pointer dereference as reported by kbuild test robot <fengguang.wu@intel.com>.
Inorder to report the kzalloc failure, I have just used a pr_debug statement. If it looks ugly, should I change the function's return value to int and give out an -ENOMEM ?
From 6615c7a995a6bb4dcf4c1e9ac59bca823ec821a5 Mon Sep 17 00:00:00 2001
From: Aurabindo J <mail@aurabindo.in>
Date: Wed, 21 May 2014 11:18:10 +0530
Subject: [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame
On systems with CONFIG_FRAME_WARN=1024, compiler warns the allocation of
an object of struct device on stack. Make the allocation dynamically to
fix the warning.
Signed-off-by: Aurabindo J <mail@aurabindo.in>
---
drivers/mfd/abx500-core.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/mfd/abx500-core.c b/drivers/mfd/abx500-core.c
index f3a15aa..5e5098d 100644
--- a/drivers/mfd/abx500-core.c
+++ b/drivers/mfd/abx500-core.c
@@ -154,16 +154,21 @@ EXPORT_SYMBOL(abx500_startup_irq_enabled);
void abx500_dump_all_banks(void)
{
struct abx500_ops *ops;
- struct device dummy_child = {NULL};
+ struct device *dummy_child;
struct abx500_device_entry *dev_entry;
- list_for_each_entry(dev_entry, &abx500_list, list) {
- dummy_child.parent = dev_entry->dev;
- ops = &dev_entry->ops;
+ dummy_child = kzalloc(sizeof(struct device), GFP_KERNEL);
+ if (dummy_child != NULL) {
+ list_for_each_entry(dev_entry, &abx500_list, list) {
+ dummy_child->parent = dev_entry->dev;
+ ops = &dev_entry->ops;
- if ((ops != NULL) && (ops->dump_all_banks != NULL))
- ops->dump_all_banks(&dummy_child);
- }
+ if ((ops != NULL) && (ops->dump_all_banks != NULL))
+ ops->dump_all_banks(dummy_child);
+ }
+ kfree(dummy_child);
+ } else
+ pr_debug("kzalloc failure in abx500_dump_all_banks\n");
}
EXPORT_SYMBOL(abx500_dump_all_banks);
--
1.9.1
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 278 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V2] mfd: abx500-core: Fix compiler warning larger stack frame
2014-05-21 6:15 ` [PATCH V2] " Jay Aurabind
@ 2014-05-21 9:17 ` Lee Jones
2014-05-21 17:19 ` Jay Aurabind
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2014-05-21 9:17 UTC (permalink / raw)
To: Jay Aurabind
Cc: Linus Walleij, Samuel Ortiz, linux-arm-kernel, linux-kernel,
kbuild test robot
> Change from V1 -> V2: Fix a potential null pointer dereference as reported by kbuild test robot <fengguang.wu@intel.com>.
>
> Inorder to report the kzalloc failure, I have just used a pr_debug statement. If it looks ugly, should I change the function's return value to int and give out an -ENOMEM ?
Yes, please do that - and obviously add the checks to the calling code.
> From 6615c7a995a6bb4dcf4c1e9ac59bca823ec821a5 Mon Sep 17 00:00:00 2001
> From: Aurabindo J <mail@aurabindo.in>
> Date: Wed, 21 May 2014 11:18:10 +0530
> Subject: [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame
>
> On systems with CONFIG_FRAME_WARN=1024, compiler warns the allocation of
> an object of struct device on stack. Make the allocation dynamically to
> fix the warning.
>
> Signed-off-by: Aurabindo J <mail@aurabindo.in>
> ---
> drivers/mfd/abx500-core.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mfd/abx500-core.c b/drivers/mfd/abx500-core.c
> index f3a15aa..5e5098d 100644
> --- a/drivers/mfd/abx500-core.c
> +++ b/drivers/mfd/abx500-core.c
> @@ -154,16 +154,21 @@ EXPORT_SYMBOL(abx500_startup_irq_enabled);
> void abx500_dump_all_banks(void)
> {
> struct abx500_ops *ops;
> - struct device dummy_child = {NULL};
> + struct device *dummy_child;
> struct abx500_device_entry *dev_entry;
>
> - list_for_each_entry(dev_entry, &abx500_list, list) {
> - dummy_child.parent = dev_entry->dev;
> - ops = &dev_entry->ops;
> + dummy_child = kzalloc(sizeof(struct device), GFP_KERNEL);
> + if (dummy_child != NULL) {
> + list_for_each_entry(dev_entry, &abx500_list, list) {
> + dummy_child->parent = dev_entry->dev;
> + ops = &dev_entry->ops;
>
> - if ((ops != NULL) && (ops->dump_all_banks != NULL))
> - ops->dump_all_banks(&dummy_child);
> - }
> + if ((ops != NULL) && (ops->dump_all_banks != NULL))
> + ops->dump_all_banks(dummy_child);
> + }
> + kfree(dummy_child);
> + } else
> + pr_debug("kzalloc failure in abx500_dump_all_banks\n");
> }
> EXPORT_SYMBOL(abx500_dump_all_banks);
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH V2] mfd: abx500-core: Fix compiler warning larger stack frame
2014-05-21 9:17 ` Lee Jones
@ 2014-05-21 17:19 ` Jay Aurabind
2014-05-22 8:42 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Jay Aurabind @ 2014-05-21 17:19 UTC (permalink / raw)
To: Lee Jones
Cc: Linus Walleij, Samuel Ortiz, linux-arm-kernel, linux-kernel,
kbuild test robot
[-- Attachment #1: Type: text/plain, Size: 3349 bytes --]
On Wednesday 21 May 2014 02:47 PM, Lee Jones wrote:
>> Change from V1 -> V2: Fix a potential null pointer dereference as reported by kbuild test robot <fengguang.wu@intel.com>.
>>
>> Inorder to report the kzalloc failure, I have just used a pr_debug statement. If it looks ugly, should I change the function's return value to int and give out an -ENOMEM ?
>
> Yes, please do that - and obviously add the checks to the calling code.
But I cannot find any calling code. At least thats what linux cross reference has to say.
Change from V2 -> V3:
Change abx500_dump_all_banks to return int so as to account for error handling.
Change from V1 -> V2:
Fix a potential null pointer dereference as reported by kbuild test robot <fengguang.wu@intel.com>.
From 19d34af7240498b2e624e94b2d003f3d9928dee8 Mon Sep 17 00:00:00 2001
From: Aurabindo J <mail@aurabindo.in>
Date: Wed, 21 May 2014 22:27:30 +0530
Subject: [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
On systems with CONFIG_FRAME_WARN=1024, compiler warns the allocation of
an object of struct device on stack. Make the allocation dynamically to
fix the warning. Also change the caller's return type to int so as to
account for error handling.
drivers/mfd/abx500-core.c: In function ‘abx500_dump_all_banks’:
drivers/mfd/abx500-core.c:167:1: warning: the frame size of 1032 bytes
is larger than 1024 bytes [-Wframe-larger-than=]
Signed-off-by: Aurabindo J <mail@aurabindo.in>
---
drivers/mfd/abx500-core.c | 12 ++++++++----
include/linux/mfd/abx500.h | 2 +-
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/abx500-core.c b/drivers/mfd/abx500-core.c
index f3a15aa..d6d0ec4 100644
--- a/drivers/mfd/abx500-core.c
+++ b/drivers/mfd/abx500-core.c
@@ -151,19 +151,23 @@ int abx500_startup_irq_enabled(struct device *dev, unsigned int irq)
}
EXPORT_SYMBOL(abx500_startup_irq_enabled);
-void abx500_dump_all_banks(void)
+int abx500_dump_all_banks(void)
{
struct abx500_ops *ops;
- struct device dummy_child = {NULL};
+ struct device *dummy_child;
struct abx500_device_entry *dev_entry;
+ dummy_child = kzalloc(sizeof(struct device), GFP_KERNEL);
+ if (!dummy_child)
+ return -ENOMEM;
list_for_each_entry(dev_entry, &abx500_list, list) {
- dummy_child.parent = dev_entry->dev;
+ dummy_child->parent = dev_entry->dev;
ops = &dev_entry->ops;
if ((ops != NULL) && (ops->dump_all_banks != NULL))
- ops->dump_all_banks(&dummy_child);
+ ops->dump_all_banks(dummy_child);
}
+ kfree(dummy_child);
}
EXPORT_SYMBOL(abx500_dump_all_banks);
diff --git a/include/linux/mfd/abx500.h b/include/linux/mfd/abx500.h
index 3301b20..df2508f 100644
--- a/include/linux/mfd/abx500.h
+++ b/include/linux/mfd/abx500.h
@@ -330,7 +330,7 @@ int abx500_mask_and_set_register_interruptible(struct device *dev, u8 bank,
int abx500_get_chip_id(struct device *dev);
int abx500_event_registers_startup_state_get(struct device *dev, u8 *event);
int abx500_startup_irq_enabled(struct device *dev, unsigned int irq);
-void abx500_dump_all_banks(void);
+int abx500_dump_all_banks(void);
struct abx500_ops {
int (*get_chip_id) (struct device *);
--
1.9.1
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 278 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V2] mfd: abx500-core: Fix compiler warning larger stack frame
2014-05-21 17:19 ` Jay Aurabind
@ 2014-05-22 8:42 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2014-05-22 8:42 UTC (permalink / raw)
To: Jay Aurabind
Cc: Linus Walleij, Samuel Ortiz, linux-arm-kernel, linux-kernel,
kbuild test robot
> >> Inorder to report the kzalloc failure, I have just used a pr_debug statement. If it looks ugly, should I change the function's return value to int and give out an -ENOMEM ?
> >
> > Yes, please do that - and obviously add the checks to the calling code.
>
> But I cannot find any calling code. At least thats what linux cross reference has to say.
Okay, thanks.
I've applied this patch and removed the other.
> Change from V2 -> V3:
> Change abx500_dump_all_banks to return int so as to account for error handling.
>
> Change from V1 -> V2:
> Fix a potential null pointer dereference as reported by kbuild test robot <fengguang.wu@intel.com>.
>
> From 19d34af7240498b2e624e94b2d003f3d9928dee8 Mon Sep 17 00:00:00 2001
> From: Aurabindo J <mail@aurabindo.in>
> Date: Wed, 21 May 2014 22:27:30 +0530
> Subject: [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> On systems with CONFIG_FRAME_WARN=1024, compiler warns the allocation of
> an object of struct device on stack. Make the allocation dynamically to
> fix the warning. Also change the caller's return type to int so as to
> account for error handling.
>
> drivers/mfd/abx500-core.c: In function ‘abx500_dump_all_banks’:
> drivers/mfd/abx500-core.c:167:1: warning: the frame size of 1032 bytes
> is larger than 1024 bytes [-Wframe-larger-than=]
>
> Signed-off-by: Aurabindo J <mail@aurabindo.in>
> ---
> drivers/mfd/abx500-core.c | 12 ++++++++----
> include/linux/mfd/abx500.h | 2 +-
> 2 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mfd/abx500-core.c b/drivers/mfd/abx500-core.c
> index f3a15aa..d6d0ec4 100644
> --- a/drivers/mfd/abx500-core.c
> +++ b/drivers/mfd/abx500-core.c
> @@ -151,19 +151,23 @@ int abx500_startup_irq_enabled(struct device *dev, unsigned int irq)
> }
> EXPORT_SYMBOL(abx500_startup_irq_enabled);
>
> -void abx500_dump_all_banks(void)
> +int abx500_dump_all_banks(void)
> {
> struct abx500_ops *ops;
> - struct device dummy_child = {NULL};
> + struct device *dummy_child;
> struct abx500_device_entry *dev_entry;
>
> + dummy_child = kzalloc(sizeof(struct device), GFP_KERNEL);
> + if (!dummy_child)
> + return -ENOMEM;
> list_for_each_entry(dev_entry, &abx500_list, list) {
> - dummy_child.parent = dev_entry->dev;
> + dummy_child->parent = dev_entry->dev;
> ops = &dev_entry->ops;
>
> if ((ops != NULL) && (ops->dump_all_banks != NULL))
> - ops->dump_all_banks(&dummy_child);
> + ops->dump_all_banks(dummy_child);
> }
> + kfree(dummy_child);
> }
> EXPORT_SYMBOL(abx500_dump_all_banks);
>
> diff --git a/include/linux/mfd/abx500.h b/include/linux/mfd/abx500.h
> index 3301b20..df2508f 100644
> --- a/include/linux/mfd/abx500.h
> +++ b/include/linux/mfd/abx500.h
> @@ -330,7 +330,7 @@ int abx500_mask_and_set_register_interruptible(struct device *dev, u8 bank,
> int abx500_get_chip_id(struct device *dev);
> int abx500_event_registers_startup_state_get(struct device *dev, u8 *event);
> int abx500_startup_irq_enabled(struct device *dev, unsigned int irq);
> -void abx500_dump_all_banks(void);
> +int abx500_dump_all_banks(void);
>
> struct abx500_ops {
> int (*get_chip_id) (struct device *);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-22 8:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-10 12:02 [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame Jay Aurabind
2014-05-20 15:20 ` Lee Jones
2014-05-21 6:15 ` [PATCH V2] " Jay Aurabind
2014-05-21 9:17 ` Lee Jones
2014-05-21 17:19 ` Jay Aurabind
2014-05-22 8:42 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox