From: Michal Simek <monstr@monstr.eu>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] microblaze: remove check for CONFIG_XILINX_CONSOLE
Date: Thu, 22 May 2014 09:47:33 +0200 [thread overview]
Message-ID: <537DAB95.8060500@monstr.eu> (raw)
In-Reply-To: <1400579750.4912.24.camel@x220>
[-- Attachment #1: Type: text/plain, Size: 1420 bytes --]
On 05/20/2014 11:55 AM, Paul Bolle wrote:
> There's been a check for CONFIG_XILINX_CONSOLE since v2.6.30. But the
> Kconfig symbol XILINX_CONSOLE was never added. Remove this check.
>
> And, since DUMMY_CONSOLE depends on VT, we can now drop the check for
> CONFIG_VT.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested.
>
> Note that xil_con doesn't exit either.
>
> arch/microblaze/kernel/setup.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/arch/microblaze/kernel/setup.c b/arch/microblaze/kernel/setup.c
> index bd422794a651..3a93843d346c 100644
> --- a/arch/microblaze/kernel/setup.c
> +++ b/arch/microblaze/kernel/setup.c
> @@ -71,13 +71,9 @@ void __init setup_arch(char **cmdline_p)
>
> xilinx_pci_init();
>
> -#ifdef CONFIG_VT
> -#if defined(CONFIG_XILINX_CONSOLE)
> - conswitchp = &xil_con;
> -#elif defined(CONFIG_DUMMY_CONSOLE)
> +#if defined(CONFIG_DUMMY_CONSOLE)
> conswitchp = &dummy_con;
> #endif
> -#endif
> }
>
> #ifdef CONFIG_MTD_UCLINUX
Looks reasonable.
Applied.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2014-05-22 7:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 9:55 [PATCH] microblaze: remove check for CONFIG_XILINX_CONSOLE Paul Bolle
2014-05-22 7:47 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537DAB95.8060500@monstr.eu \
--to=monstr@monstr.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox