Re: [RFC PATCH 08/16] mtd: nand: omap: Fix build warning

Jingoo Han
2014-05-22T00:54:55Z

On Wednesday, May 21, 2014 8:21 PM, Roger Quadros wrote:
>
> Fix the following warning when CONFIG_MTD_NAND_OMAP_BCH is disabled.
> warning: ‘erased_sector_bitflips’ defined but not used [-Wunused-function]
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>

(+cc Christian Engelmayer)

The same patch was already sent by Christian Engelmayer. [1]
Also, it was applied to mtd tree by Brian Norris. [2]
Thank you.

[1] http://lists.infradead.org/pipermail/linux-mtd/2014-April/053330.html
[2] http://git.infradead.org/users/dedekind/l2-mtd.git/commit/9fd6c6c18c1a4a3220473c76fd447c5708b5ecf9

Best regards,
Jingoo Han

> ---
> drivers/mtd/nand/omap2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 1ff49b8..1b800bc 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1237,6 +1237,7 @@ static int __maybe_unused omap_calculate_ecc_bch(struct mtd_info *mtd,
> return 0;
> }
>
> +#ifdef CONFIG_MTD_NAND_OMAP_BCH
> /**
> * erased_sector_bitflips - count bit flips
> * @data: data sector buffer
> @@ -1276,7 +1277,6 @@ static int erased_sector_bitflips(u_char *data, u_char *oob,
> return flip_bits;
> }
>
> -#ifdef CONFIG_MTD_NAND_OMAP_BCH
> /**
> * omap_elm_correct_data - corrects page data area in case error reported
> * @mtd: MTD device structure
> --
> 1.8.3.2