public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: Chase Southwood <chase.southwood@gmail.com>,
	<gregkh@linuxfoundation.org>
Cc: <hsweeten@visionengravers.com>, <devel@driverdev.osuosl.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] staging: comedi: addi_apci_1564: move apci1564_do_insn_bits() to addi_apci_1564.c
Date: Thu, 22 May 2014 10:25:44 +0100	[thread overview]
Message-ID: <537DC298.1000200@mev.co.uk> (raw)
In-Reply-To: <1400719275-21780-1-git-send-email-chase.southwood@gmail.com>

On 2014-05-22 01:41, Chase Southwood wrote:
> This function is already compliant with the comedi API and is behaving as
> comedi core expects.  This patch moves it out of
> addi-data/hwdrv_apci1564.c and into the driver proper since no further
> work needs to be done on it.
>
> Cc: Ian Abbott <abbotti@mev.co.uk>
> Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
> Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
> ---
> Just a couple patches in this set, but with these out of the way, the
> next patchset can focus entirely on getting the change-of-state interrupt
> functionality working.  Made sense to just finish up with DI/DO and start
> COS interrupts separately.
>
>   .../staging/comedi/drivers/addi-data/hwdrv_apci1564.c   | 17 -----------------
>   drivers/staging/comedi/drivers/addi_apci_1564.c         | 17 +++++++++++++++++
>   2 files changed, 17 insertions(+), 17 deletions(-)

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-

  reply	other threads:[~2014-05-22  9:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-22  0:40 [PATCH 1/2] staging: comedi: addi_apci_1564: move apci1564_di_insn_bits() to addi_apci_1564.c Chase Southwood
2014-05-22  0:41 ` [PATCH 2/2] staging: comedi: addi_apci_1564: move apci1564_do_insn_bits() " Chase Southwood
2014-05-22  9:25   ` Ian Abbott [this message]
2014-05-22 16:33   ` Hartley Sweeten
2014-05-22  9:24 ` [PATCH 1/2] staging: comedi: addi_apci_1564: move apci1564_di_insn_bits() " Ian Abbott
2014-05-22 16:31 ` Hartley Sweeten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537DC298.1000200@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=chase.southwood@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox