Re: [PATCH] mfd: axp20x: Remove unnecessary const qualifier from axp20x_supplies[]

Lee Jones
2014-05-22T16:09:05Z

> > drivers/mfd/axp20x.c:159:3:
> > warning: initialization discards ‘const’ qualifier from pointer target type
> > .parent_supplies = axp20x_supplies,
> []
> > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> []
> > @@ -140,7 +140,7 @@ static const struct regmap_irq_chip axp20x_regmap_irq_chip = {
> > .init_ack_masked = true,
> > };
> >
> > -static const char * const axp20x_supplies[] = {
> > +static const char * axp20x_supplies[] = {
> > "acin",
> > "vin2",
> > "vin3",
>
> Perhaps you're doing this the wrong way round.
> Maybe this definition should change.
>
> include/linux/mfd/core.h: const char **parent_supplies;

Are you asking me, or telling me? :)

To be frank, I've never known what the double const means. Care to
enlighten?

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog