Re: [PATCH v5 5/6] usb: musb: dsps: Add the sw_babble_control()

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

On 22-05-2014 10:29, George Cherian wrote:

> Add sw_babble_control() logic to differentiate between transient
> babble and real babble condition. Also add the SW babble control
> register definitions.

> Babble control register logic is implemented in the latest
> revision of AM335x.

> Signed-off-by: George Cherian <george.cherian@ti.com>
> ---
>   drivers/usb/musb/musb_dsps.c | 50 ++++++++++++++++++++++++++++++++++++++++++++
>   drivers/usb/musb/musb_regs.h |  7 +++++++
>   2 files changed, 57 insertions(+)

> diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
> index f6f3087..868caf8 100644
> --- a/drivers/usb/musb/musb_dsps.c
> +++ b/drivers/usb/musb/musb_dsps.c
> @@ -536,6 +536,56 @@ static int dsps_musb_set_mode(struct musb *musb, u8 mode)
>   	return 0;
>   }
>
> +static int sw_babble_control(struct musb *musb)
> +{

    Doesn't gcc complain on this function being unused? I think you should 
have added this function along with the caller, not separately.

WBR, Sergei