From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Yang,Wei" <Wei.Yang@windriver.com>
Cc: tglx@linutronix.de, rostedt@goodmis.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] drivers/clocksource: do not trace read_sched_clock
Date: Thu, 22 May 2014 14:03:14 +0200 [thread overview]
Message-ID: <537DE782.7040408@linaro.org> (raw)
In-Reply-To: <537D57CA.6000305@windriver.com>
On 05/22/2014 03:50 AM, Yang,Wei wrote:
> Hi Daniel,
>
> What do you think of it?
>
> Regards
> Wei
> On 05/13/2014 11:10 AM, Wei.Yang@windriver.com wrote:
>> From: Yang Wei <Wei.Yang@windriver.com>
>>
>> We do not need to trace read_sched_clock function,
>> so add notrace attribute for this function.
Hi Yang,
I agree with your patch. Applied in my tree for 3.16
Please in the future fix the subject name:
clocksource: [driver]: [A-Z]....
Thanks
-- Daniel
>> Signed-off-by: Yang Wei <Wei.Yang@windriver.com>
>> ---
>> drivers/clocksource/dw_apb_timer_of.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clocksource/dw_apb_timer_of.c
>> b/drivers/clocksource/dw_apb_timer_of.c
>> index 2a2ea27..d305fb0 100644
>> --- a/drivers/clocksource/dw_apb_timer_of.c
>> +++ b/drivers/clocksource/dw_apb_timer_of.c
>> @@ -106,7 +106,7 @@ static void __init add_clocksource(struct
>> device_node *source_timer)
>> sched_rate = rate;
>> }
>> -static u64 read_sched_clock(void)
>> +static u64 notrace read_sched_clock(void)
>> {
>> return ~__raw_readl(sched_io_base);
>> }
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2014-05-22 12:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 3:10 [PATCH v1] drivers/clocksource: do not trace read_sched_clock Wei.Yang
2014-05-22 1:50 ` Yang,Wei
2014-05-22 12:03 ` Daniel Lezcano [this message]
2014-05-23 0:51 ` Yang,Wei
-- strict thread matches above, loose matches on Subject: below --
2014-05-13 3:09 Wei.Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537DE782.7040408@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=Wei.Yang@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox