From: Stephen Warren <swarren@wwwdotorg.org>
To: Tushar Behera <tushar.behera@linaro.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Cc: tiwai@suse.de, perex@perex.cz, broonie@kernel.org,
dianders@chromium.org, jerry.wong@maximintegrated.com
Subject: Re: [PATCH 1/2] ASoC: max98090: Add master clock handling
Date: Thu, 22 May 2014 09:51:38 -0600 [thread overview]
Message-ID: <537E1D0A.6020303@wwwdotorg.org> (raw)
In-Reply-To: <1400750228-13750-2-git-send-email-tushar.behera@linaro.org>
On 05/22/2014 03:17 AM, Tushar Behera wrote:
> If master clock is provided through device tree, then update
> the master clock frequency during set_sysclk.
>
> Documentation has been updated to reflect the change.
> diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c
> @@ -1929,6 +1930,11 @@ static int max98090_dai_set_sysclk(struct snd_soc_dai *dai,
> if (freq == max98090->sysclk)
> return 0;
>
> + if (!IS_ERR(max98090->mclk)) {
> + freq = clk_round_rate(max98090->mclk, freq);
> + clk_set_rate(max98090->mclk, freq);
> + }
What are the intended semantics of set_sysclk()?
sound/soc/tegra/tegra_wm98090.c assumes that set_sysclk() is a
notification to the CODEC driver to tell it what rate the MCLK input is
set to (the rate is set before calling set_sysclk), whereas the code
above assumes that this function is to tell the CODEC to somehow
configure its input clock to be a particular rate. I have a feeling the
code above might fail on Tegra.
next prev parent reply other threads:[~2014-05-22 15:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 9:17 [PATCH 0/2] ASoC: max98090/max98095: Add master clock handing Tushar Behera
2014-05-22 9:17 ` [PATCH 1/2] ASoC: max98090: Add master clock handling Tushar Behera
2014-05-22 10:30 ` Mark Brown
2014-05-23 5:35 ` Tushar Behera
2014-05-23 11:14 ` Mark Brown
2014-05-23 11:36 ` Tushar Behera
2014-05-23 11:41 ` Mark Brown
2014-05-23 12:02 ` Tushar Behera
2014-05-22 15:51 ` Stephen Warren [this message]
2014-05-22 17:34 ` Mark Brown
2014-05-22 17:50 ` Stephen Warren
2014-05-22 18:19 ` Mark Brown
2014-05-22 22:24 ` Stephen Warren
2014-05-22 23:36 ` Mark Brown
2014-05-22 9:17 ` [PATCH 2/2] ASoC: max98095: " Tushar Behera
2014-05-22 10:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537E1D0A.6020303@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=jerry.wong@maximintegrated.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox