From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752574AbaEVPxJ (ORCPT ); Thu, 22 May 2014 11:53:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19195 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752229AbaEVPxH (ORCPT ); Thu, 22 May 2014 11:53:07 -0400 Message-ID: <537E1D4E.4040407@redhat.com> Date: Thu, 22 May 2014 11:52:46 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Mel Gorman , Andrew Morton CC: Johannes Weiner , Hugh Dickins , Tim Chen , Dave Chinner , Yuanhan Liu , Bob Liu , Jan Kara , Linux Kernel , Linux-MM , Linux-FSDevel Subject: Re: [PATCH 1/3] fs/superblock: Unregister sb shrinker before ->kill_sb() References: <1400749779-24879-1-git-send-email-mgorman@suse.de> <1400749779-24879-2-git-send-email-mgorman@suse.de> In-Reply-To: <1400749779-24879-2-git-send-email-mgorman@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/22/2014 05:09 AM, Mel Gorman wrote: > From: Dave Chinner > > We will like to unregister the sb shrinker before ->kill_sb(). > This will allow cached objects to be counted without call to > grab_super_passive() to update ref count on sb. We want > to avoid locking during memory reclamation especially when > we are skipping the memory reclaim when we are out of > cached objects. > Signed-off-by: Tim Chen > Signed-off-by: Mel Gorman Acked-by: Rik van Riel -- All rights reversed