From: Jim Baxter <jim_baxter@mentor.com>
To: "David Laight" <David.Laight@ACULAB.COM>, "'Bjørn Mork'" <bjorn@mork.no>
Cc: "'Eric Dumazet'" <eric.dumazet@gmail.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"kamal@canonical.com" <kamal@canonical.com>,
"edumazet@google.com" <edumazet@google.com>,
"mszeredi@suse.cz" <mszeredi@suse.cz>,
"fw@strlen.de" <fw@strlen.de>
Subject: Re: skbuff truesize incorrect.
Date: Fri, 23 May 2014 12:13:23 +0100 [thread overview]
Message-ID: <537F2D53.5020408@mentor.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1724C7A1@AcuExch.aculab.com>
On 23/05/14 11:45, David Laight wrote:
> From: Bjørn Mork [mailto:bjorn@mork.no]
>> David Laight <David.Laight@ACULAB.COM> writes:
> ...
>>> Note that some of the usb ethernet drivers allocate large skb then
>>> lie about the truesize.
>>
>> Hmm, which drivers are these?
>
> $ grep truesize linux/drivers/net/usb/*
>
> asix_88179_178a, smsc95xx, sr9700.
>
> David
>
What are the side effects of changing the truesize, if the original
uncloned skb has the full truesize then isn't the potential memory usage
still counted for the avoidance of OOM?
I suppose if the uncloned skb is deleted you would then have a problem
so a chain of URB's would be the safest solution.
Jim
next prev parent reply other threads:[~2014-05-23 11:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 19:07 skbuff truesize incorrect Jim Baxter
2014-05-22 19:21 ` David Miller
2014-05-22 20:21 ` Jim Baxter
2014-05-22 20:30 ` Eric Dumazet
2014-05-22 20:58 ` David Miller
2014-05-23 9:21 ` Jim Baxter
2014-05-23 9:27 ` David Laight
2014-05-23 16:46 ` David Miller
2014-05-22 19:25 ` Vlad Yasevich
2014-05-22 19:39 ` Jim Baxter
2014-05-22 19:59 ` Eric Dumazet
2014-05-22 20:21 ` Jim Baxter
2014-05-22 20:58 ` Eric Dumazet
2014-05-22 21:03 ` Eric Dumazet
2014-05-22 21:10 ` David Miller
2014-05-23 7:07 ` Bjørn Mork
2014-05-23 8:58 ` Jim Baxter
2014-05-23 9:33 ` Bjørn Mork
2014-05-23 14:00 ` Eric Dumazet
2014-05-23 15:44 ` Rick Jones
2014-05-23 16:00 ` Eric Dumazet
2014-05-23 8:52 ` David Laight
2014-05-23 9:48 ` Bjørn Mork
2014-05-23 10:45 ` David Laight
2014-05-23 11:13 ` Jim Baxter [this message]
2014-05-23 13:47 ` Eric Dumazet
2014-05-23 15:00 ` Jim Baxter
2014-05-23 15:30 ` David Laight
2014-05-23 15:41 ` Eric Dumazet
2014-05-23 20:18 ` David Miller
2014-05-27 15:23 ` David Laight
2014-05-27 15:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537F2D53.5020408@mentor.com \
--to=jim_baxter@mentor.com \
--cc=David.Laight@ACULAB.COM \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=kamal@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mszeredi@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox