From: Tarek Dakhran <t.dakhran@samsung.com>
To: Tomasz Figa <tomasz.figa@gmail.com>, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
Kukjin Kim <kgene.kim@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Ben Dooks <ben-linux@fluff.org>, Tomasz Figa <t.figa@samsung.com>,
Mike Turquette <mturquette@linaro.org>,
Vyacheslav Tyrtov <v.tyrtov@samsung.com>,
Thomas Abraham <thomas.abraham@linaro.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Heiko Stuebner <heiko@sntech.de>,
Romain Naour <romain.naour@openwide.fr>,
Chander Kashyap <chander.kashyap@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Tarek Dakhran <t.dakhran@gmail.com>
Subject: Re: [PATCH v10 1/3] ARM: EXYNOS: Add support for EXYNOS5410 SoC
Date: Sat, 24 May 2014 13:33:13 +0400 [thread overview]
Message-ID: <53806759.40908@samsung.com> (raw)
In-Reply-To: <537FB995.5070604@gmail.com>
Hi Tomasz
I faced another problem, while changing this patch.
See below.
On 05/24/2014 01:11 AM, Tomasz Figa wrote:
> Hi Tarek,
>
> With v2 of the series I mentioned in review of previous version [1],
> this patch can be skipped.
>
> [1] http://www.spinics.net/lists/linux-samsung-soc/msg31258.html
>
> Best regards,
> Tomasz
>
> On 23.05.2014 12:35, Tarek Dakhran wrote:
>> EXYNOS5410 is SoC in Samsung's Exynos5 SoC series.
>> Add initial support for this SoC.
>>
>> Signed-off-by: Tarek Dakhran <t.dakhran@samsung.com>
>> Signed-off-by: Vyacheslav Tyrtov <v.tyrtov@samsung.com>
>> ---
>> arch/arm/mach-exynos/Kconfig | 8 ++++++++
>> arch/arm/mach-exynos/common.h | 11 ++++++++++-
>> arch/arm/mach-exynos/firmware.c | 2 +-
>> 3 files changed, 19 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
>> index 1602abc..79a3e85 100644
>> --- a/arch/arm/mach-exynos/Kconfig
>> +++ b/arch/arm/mach-exynos/Kconfig
>> @@ -84,6 +84,14 @@ config SOC_EXYNOS5250
>> help
>> Enable EXYNOS5250 SoC support
>>
>> +config SOC_EXYNOS5410
>> + bool "SAMSUNG EXYNOS5410"
>> + default y
>> + depends on ARCH_EXYNOS5
>> + select PM_GENERIC_DOMAINS if PM_RUNTIME
>> + help
>> + Enable EXYNOS5410 SoC support
>> +
>> config SOC_EXYNOS5420
>> bool "SAMSUNG EXYNOS5420"
>> default y
>> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
>> index e2d0954..d64c6de 100644
>> --- a/arch/arm/mach-exynos/common.h
>> +++ b/arch/arm/mach-exynos/common.h
>> @@ -21,6 +21,7 @@
>> #define EXYNOS4_CPU_MASK 0xFFFE0000
>>
>> #define EXYNOS5250_SOC_ID 0x43520000
>> +#define EXYNOS5410_SOC_ID 0xE5410000
>> #define EXYNOS5420_SOC_ID 0xE5420000
>> #define EXYNOS5440_SOC_ID 0xE5440000
>> #define EXYNOS5_SOC_MASK 0xFFFFF000
>> @@ -37,6 +38,7 @@ IS_SAMSUNG_CPU(exynos4210, EXYNOS4210_CPU_ID, EXYNOS4_CPU_MASK)
>> IS_SAMSUNG_CPU(exynos4212, EXYNOS4212_CPU_ID, EXYNOS4_CPU_MASK)
>> IS_SAMSUNG_CPU(exynos4412, EXYNOS4412_CPU_ID, EXYNOS4_CPU_MASK)
>> IS_SAMSUNG_CPU(exynos5250, EXYNOS5250_SOC_ID, EXYNOS5_SOC_MASK)
>> +IS_SAMSUNG_CPU(exynos5410, EXYNOS5410_SOC_ID, EXYNOS5_SOC_MASK)
>> IS_SAMSUNG_CPU(exynos5420, EXYNOS5420_SOC_ID, EXYNOS5_SOC_MASK)
>> IS_SAMSUNG_CPU(exynos5440, EXYNOS5440_SOC_ID, EXYNOS5_SOC_MASK)
>>
>> @@ -68,6 +70,12 @@ IS_SAMSUNG_CPU(exynos5440, EXYNOS5440_SOC_ID, EXYNOS5_SOC_MASK)
>> # define soc_is_exynos5250() 0
>> #endif
>>
>> +#if defined(CONFIG_SOC_EXYNOS5410)
>> +# define soc_is_exynos5410() is_samsung_exynos5410()
>> +#else
>> +# define soc_is_exynos5410() 0
>> +#endif
>> +
>> #if defined(CONFIG_SOC_EXYNOS5420)
>> # define soc_is_exynos5420() is_samsung_exynos5420()
>> #else
>> @@ -82,7 +90,8 @@ IS_SAMSUNG_CPU(exynos5440, EXYNOS5440_SOC_ID, EXYNOS5_SOC_MASK)
>>
>> #define soc_is_exynos4() (soc_is_exynos4210() || soc_is_exynos4212() || \
>> soc_is_exynos4412())
>> -#define soc_is_exynos5() (soc_is_exynos5250() || soc_is_exynos5420())
>> +#define soc_is_exynos5() (soc_is_exynos5250() || soc_is_exynos5410() || \
>> + soc_is_exynos5420())
>>
This is the place where we need it.
Or this macro should be changed (maybe read compatible property from dt).
--
Best regards,
Tarek Dakhran
next prev parent reply other threads:[~2014-05-24 9:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 10:35 [PATCH v10 0/3] Exynos 5410 support Tarek Dakhran
2014-05-23 10:35 ` [PATCH v10 1/3] ARM: EXYNOS: Add support for EXYNOS5410 SoC Tarek Dakhran
2014-05-23 21:11 ` Tomasz Figa
2014-05-23 22:44 ` Tarek Dakhran
2014-05-23 22:48 ` Tomasz Figa
2014-05-23 22:48 ` Tarek Dakhran
2014-05-23 22:55 ` Tomasz Figa
2014-05-24 9:33 ` Tarek Dakhran [this message]
2014-05-24 17:44 ` Tomasz Figa
2014-05-23 10:35 ` [PATCH v10 2/3] clk: exynos5410: register clocks using common clock framework Tarek Dakhran
2014-05-23 18:28 ` Mike Turquette
2014-05-23 21:19 ` Tomasz Figa
2014-05-23 22:52 ` Tarek Dakhran
2014-05-23 10:35 ` [PATCH v10 3/3] ARM: dts: Add initial device tree support for EXYNOS5410 Tarek Dakhran
2014-05-23 17:02 ` Matthias Brugger
2014-05-23 21:15 ` Tomasz Figa
2014-05-25 20:09 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53806759.40908@samsung.com \
--to=t.dakhran@samsung.com \
--cc=ben-linux@fluff.org \
--cc=chander.kashyap@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=romain.naour@openwide.fr \
--cc=t.dakhran@gmail.com \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
--cc=tomasz.figa@gmail.com \
--cc=v.tyrtov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox