From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751238AbaEXJda (ORCPT ); Sat, 24 May 2014 05:33:30 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:59389 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750882AbaEXJd0 (ORCPT ); Sat, 24 May 2014 05:33:26 -0400 X-AuditID: cbfec7f5-b7f626d000004b39-a2-53806762bc31 Message-id: <53806759.40908@samsung.com> Date: Sat, 24 May 2014 13:33:13 +0400 From: Tarek Dakhran User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-version: 1.0 To: Tomasz Figa , linux-kernel@vger.kernel.org Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Rob Landley , Kukjin Kim , Russell King , Ben Dooks , Tomasz Figa , Mike Turquette , Vyacheslav Tyrtov , Thomas Abraham , Kyungmin Park , Heiko Stuebner , Romain Naour , Chander Kashyap , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Tarek Dakhran Subject: Re: [PATCH v10 1/3] ARM: EXYNOS: Add support for EXYNOS5410 SoC References: <1400841343-6016-1-git-send-email-t.dakhran@samsung.com> <1400841343-6016-2-git-send-email-t.dakhran@samsung.com> <537FB995.5070604@gmail.com> In-reply-to: <537FB995.5070604@gmail.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsVy+t/xK7pJ6Q3BBue/8FhMWneAyeLh+pss FvOPnGO16H+zkNXi/6PXrBbnXq1ktOhdcJXN4mzTG3aLTY+vsVosbFvCYnF51xw2ixnn9zFZ 3L7Ma7H0+kUmi6cTLrJZTJi+lsVi3cvpLBate4+wW2z52cFo8bvnE7PF+hmvWSyOzVjCaLFq 1x9Gi6kzfrA7SHismbeG0aOluYfN43JfL5PH31UvmD12zrrL7rFy+Rc2j02rOtk8Xq2eyepx 59oeNo/NS+o9Xl1j8ejbsorRY/u1ecwenzfJBfBFcdmkpOZklqUW6dslcGWcnXmOrWClVEXH 1bUsDYzPRbsYOTkkBEwkTr+cyw5hi0lcuLeerYuRi0NIYCmjxP+G7awQzgdGia4Vr9lAqngF NCQ+vl3N3MXIwcEioCqxsZ8fxGQT0JbYssMLpEJUIELiXuNhVohqQYkfk++xgNgiAq4SnTs/ MoLYzAIn2SQW/dQHsYUFPCQ+7dzLBLFqHqPEiuf/wA7iFNCU6Dt/mxmiwVpi5aRtUM3yEpvX vGWewCgwC8mOWUjKZiEpW8DIvIpRNLU0uaA4KT3XSK84Mbe4NC9dLzk/dxMjJMa/7mBceszq EKMAB6MSD28DW0OwEGtiWXFl7iFGCQ5mJRHe6CigEG9KYmVValF+fFFpTmrxIUYmDk6pBsaK foaI2nUykowFDdP133GpCzFU6Qu4HT/EUfPsgCrr8cvaYhoTNH79Oi24k3ehrA1Dyce3uz2n cZ7t4K3x/lEi5enPqSg/6QJTcAijRPmFgMuPKnTCD1lKXnL9FHLUW+NR7CS3npCvJf2Oj/le MCa33Dsm6yQ76eL0G7++8ZRccF3b2HT3jBJLcUaioRZzUXEiAHwKkSPPAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomasz I faced another problem, while changing this patch. See below. On 05/24/2014 01:11 AM, Tomasz Figa wrote: > Hi Tarek, > > With v2 of the series I mentioned in review of previous version [1], > this patch can be skipped. > > [1] http://www.spinics.net/lists/linux-samsung-soc/msg31258.html > > Best regards, > Tomasz > > On 23.05.2014 12:35, Tarek Dakhran wrote: >> EXYNOS5410 is SoC in Samsung's Exynos5 SoC series. >> Add initial support for this SoC. >> >> Signed-off-by: Tarek Dakhran >> Signed-off-by: Vyacheslav Tyrtov >> --- >> arch/arm/mach-exynos/Kconfig | 8 ++++++++ >> arch/arm/mach-exynos/common.h | 11 ++++++++++- >> arch/arm/mach-exynos/firmware.c | 2 +- >> 3 files changed, 19 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig >> index 1602abc..79a3e85 100644 >> --- a/arch/arm/mach-exynos/Kconfig >> +++ b/arch/arm/mach-exynos/Kconfig >> @@ -84,6 +84,14 @@ config SOC_EXYNOS5250 >> help >> Enable EXYNOS5250 SoC support >> >> +config SOC_EXYNOS5410 >> + bool "SAMSUNG EXYNOS5410" >> + default y >> + depends on ARCH_EXYNOS5 >> + select PM_GENERIC_DOMAINS if PM_RUNTIME >> + help >> + Enable EXYNOS5410 SoC support >> + >> config SOC_EXYNOS5420 >> bool "SAMSUNG EXYNOS5420" >> default y >> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h >> index e2d0954..d64c6de 100644 >> --- a/arch/arm/mach-exynos/common.h >> +++ b/arch/arm/mach-exynos/common.h >> @@ -21,6 +21,7 @@ >> #define EXYNOS4_CPU_MASK 0xFFFE0000 >> >> #define EXYNOS5250_SOC_ID 0x43520000 >> +#define EXYNOS5410_SOC_ID 0xE5410000 >> #define EXYNOS5420_SOC_ID 0xE5420000 >> #define EXYNOS5440_SOC_ID 0xE5440000 >> #define EXYNOS5_SOC_MASK 0xFFFFF000 >> @@ -37,6 +38,7 @@ IS_SAMSUNG_CPU(exynos4210, EXYNOS4210_CPU_ID, EXYNOS4_CPU_MASK) >> IS_SAMSUNG_CPU(exynos4212, EXYNOS4212_CPU_ID, EXYNOS4_CPU_MASK) >> IS_SAMSUNG_CPU(exynos4412, EXYNOS4412_CPU_ID, EXYNOS4_CPU_MASK) >> IS_SAMSUNG_CPU(exynos5250, EXYNOS5250_SOC_ID, EXYNOS5_SOC_MASK) >> +IS_SAMSUNG_CPU(exynos5410, EXYNOS5410_SOC_ID, EXYNOS5_SOC_MASK) >> IS_SAMSUNG_CPU(exynos5420, EXYNOS5420_SOC_ID, EXYNOS5_SOC_MASK) >> IS_SAMSUNG_CPU(exynos5440, EXYNOS5440_SOC_ID, EXYNOS5_SOC_MASK) >> >> @@ -68,6 +70,12 @@ IS_SAMSUNG_CPU(exynos5440, EXYNOS5440_SOC_ID, EXYNOS5_SOC_MASK) >> # define soc_is_exynos5250() 0 >> #endif >> >> +#if defined(CONFIG_SOC_EXYNOS5410) >> +# define soc_is_exynos5410() is_samsung_exynos5410() >> +#else >> +# define soc_is_exynos5410() 0 >> +#endif >> + >> #if defined(CONFIG_SOC_EXYNOS5420) >> # define soc_is_exynos5420() is_samsung_exynos5420() >> #else >> @@ -82,7 +90,8 @@ IS_SAMSUNG_CPU(exynos5440, EXYNOS5440_SOC_ID, EXYNOS5_SOC_MASK) >> >> #define soc_is_exynos4() (soc_is_exynos4210() || soc_is_exynos4212() || \ >> soc_is_exynos4412()) >> -#define soc_is_exynos5() (soc_is_exynos5250() || soc_is_exynos5420()) >> +#define soc_is_exynos5() (soc_is_exynos5250() || soc_is_exynos5410() || \ >> + soc_is_exynos5420()) >> This is the place where we need it. Or this macro should be changed (maybe read compatible property from dt). -- Best regards, Tarek Dakhran