* [PATCH] phy: sun4i: depend on RESET_CONTROLLER
@ 2014-05-23 18:51 Maxime Ripard
2014-05-24 10:15 ` Hans de Goede
2014-06-11 9:10 ` Maxime Ripard
0 siblings, 2 replies; 6+ messages in thread
From: Maxime Ripard @ 2014-05-23 18:51 UTC (permalink / raw)
To: kishon, hdegoede
Cc: linux-kernel, linux-arm-kernel, Arnd Bergmann, Maxime Ripard
The driver depend on the reset framework in a mandatory way. Make sure
reset_control_get is defined by adding this dependency in Kconfig
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Reported-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/phy/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 16a2f067c242..1d8099a56a91 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -112,6 +112,7 @@ config PHY_EXYNOS5250_SATA
config PHY_SUN4I_USB
tristate "Allwinner sunxi SoC USB PHY driver"
depends on ARCH_SUNXI && HAS_IOMEM && OF
+ depends on RESET_CONTROLLER
select GENERIC_PHY
help
Enable this to support the transceiver that is part of Allwinner
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: sun4i: depend on RESET_CONTROLLER
2014-05-23 18:51 [PATCH] phy: sun4i: depend on RESET_CONTROLLER Maxime Ripard
@ 2014-05-24 10:15 ` Hans de Goede
2014-06-11 9:10 ` Maxime Ripard
1 sibling, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2014-05-24 10:15 UTC (permalink / raw)
To: Maxime Ripard, kishon; +Cc: linux-kernel, linux-arm-kernel, Arnd Bergmann
Hi,
On 05/23/2014 08:51 PM, Maxime Ripard wrote:
> The driver depend on the reset framework in a mandatory way. Make sure
> reset_control_get is defined by adding this dependency in Kconfig
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
Good catch.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/phy/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 16a2f067c242..1d8099a56a91 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -112,6 +112,7 @@ config PHY_EXYNOS5250_SATA
> config PHY_SUN4I_USB
> tristate "Allwinner sunxi SoC USB PHY driver"
> depends on ARCH_SUNXI && HAS_IOMEM && OF
> + depends on RESET_CONTROLLER
> select GENERIC_PHY
> help
> Enable this to support the transceiver that is part of Allwinner
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: sun4i: depend on RESET_CONTROLLER
2014-05-23 18:51 [PATCH] phy: sun4i: depend on RESET_CONTROLLER Maxime Ripard
2014-05-24 10:15 ` Hans de Goede
@ 2014-06-11 9:10 ` Maxime Ripard
2014-06-11 9:44 ` Kishon Vijay Abraham I
1 sibling, 1 reply; 6+ messages in thread
From: Maxime Ripard @ 2014-06-11 9:10 UTC (permalink / raw)
To: kishon, hdegoede; +Cc: linux-kernel, linux-arm-kernel, Arnd Bergmann
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
Hi Kishon,
On Fri, May 23, 2014 at 08:51:28PM +0200, Maxime Ripard wrote:
> The driver depend on the reset framework in a mandatory way. Make sure
> reset_control_get is defined by adding this dependency in Kconfig
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
Ping?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: sun4i: depend on RESET_CONTROLLER
2014-06-11 9:10 ` Maxime Ripard
@ 2014-06-11 9:44 ` Kishon Vijay Abraham I
2014-06-11 9:46 ` Maxime Ripard
2014-06-29 14:00 ` Maxime Ripard
0 siblings, 2 replies; 6+ messages in thread
From: Kishon Vijay Abraham I @ 2014-06-11 9:44 UTC (permalink / raw)
To: Maxime Ripard, hdegoede; +Cc: linux-kernel, linux-arm-kernel, Arnd Bergmann
Hi,
On Wednesday 11 June 2014 02:40 PM, Maxime Ripard wrote:
> Hi Kishon,
>
> On Fri, May 23, 2014 at 08:51:28PM +0200, Maxime Ripard wrote:
>> The driver depend on the reset framework in a mandatory way. Make sure
>> reset_control_get is defined by adding this dependency in Kconfig
>>
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>> Reported-by: Arnd Bergmann <arnd@arndb.de>
>
> Ping?
Will queue once -rc1 is tagged.
Cheers
Kishon
>
> Maxime
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: sun4i: depend on RESET_CONTROLLER
2014-06-11 9:44 ` Kishon Vijay Abraham I
@ 2014-06-11 9:46 ` Maxime Ripard
2014-06-29 14:00 ` Maxime Ripard
1 sibling, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2014-06-11 9:46 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: hdegoede, linux-kernel, linux-arm-kernel, Arnd Bergmann
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
On Wed, Jun 11, 2014 at 03:14:25PM +0530, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Wednesday 11 June 2014 02:40 PM, Maxime Ripard wrote:
> > Hi Kishon,
> >
> > On Fri, May 23, 2014 at 08:51:28PM +0200, Maxime Ripard wrote:
> >> The driver depend on the reset framework in a mandatory way. Make sure
> >> reset_control_get is defined by adding this dependency in Kconfig
> >>
> >> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> >> Reported-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Ping?
>
> Will queue once -rc1 is tagged.
Ok, thanks.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: sun4i: depend on RESET_CONTROLLER
2014-06-11 9:44 ` Kishon Vijay Abraham I
2014-06-11 9:46 ` Maxime Ripard
@ 2014-06-29 14:00 ` Maxime Ripard
1 sibling, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2014-06-29 14:00 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: hdegoede, linux-kernel, linux-arm-kernel, Arnd Bergmann
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
Hi Kishon,
On Wed, Jun 11, 2014 at 03:14:25PM +0530, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Wednesday 11 June 2014 02:40 PM, Maxime Ripard wrote:
> > Hi Kishon,
> >
> > On Fri, May 23, 2014 at 08:51:28PM +0200, Maxime Ripard wrote:
> >> The driver depend on the reset framework in a mandatory way. Make sure
> >> reset_control_get is defined by adding this dependency in Kconfig
> >>
> >> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> >> Reported-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Ping?
>
> Will queue once -rc1 is tagged.
We're almost at -rc3, and I don't think you merged it. It would be
great to have it in 3.16.
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-29 14:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-23 18:51 [PATCH] phy: sun4i: depend on RESET_CONTROLLER Maxime Ripard
2014-05-24 10:15 ` Hans de Goede
2014-06-11 9:10 ` Maxime Ripard
2014-06-11 9:44 ` Kishon Vijay Abraham I
2014-06-11 9:46 ` Maxime Ripard
2014-06-29 14:00 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox