From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95CF0EB64DA for ; Mon, 10 Jul 2023 09:51:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232465AbjGJJvG (ORCPT ); Mon, 10 Jul 2023 05:51:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232443AbjGJJuQ (ORCPT ); Mon, 10 Jul 2023 05:50:16 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D2F61FC6; Mon, 10 Jul 2023 02:45:13 -0700 (PDT) Received: from i53875a50.versanet.de ([83.135.90.80] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qInRy-0007zw-0Y; Mon, 10 Jul 2023 11:44:58 +0200 From: Heiko Stuebner To: Eric Biggers Cc: palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, herbert@gondor.apana.org.au, davem@davemloft.net, conor.dooley@microchip.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, christoph.muellner@vrull.eu, Heiko Stuebner Subject: Re: [PATCH v5 0/4] Implement GCM ghash using Zbc and Zbkb extensions Date: Mon, 10 Jul 2023 11:44:56 +0200 Message-ID: <5381895.Sb9uPGUboI@phil> In-Reply-To: <20230613030216.GC883@sol.localdomain> References: <20230612210442.1805962-1-heiko.stuebner@vrull.eu> <20230613030216.GC883@sol.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Eric, Am Dienstag, 13. Juni 2023, 05:02:16 CEST schrieb Eric Biggers: > Hi Heiko, > > On Mon, Jun 12, 2023 at 11:04:38PM +0200, Heiko Stuebner wrote: > > From: Heiko Stuebner > > > > This was originally part of my vector crypto series, but was part > > of a separate openssl merge request implementing GCM ghash as using > > non-vector extensions. > > > > As that pull-request > > https://github.com/openssl/openssl/pull/20078 > > got merged recently into openssl, we could also check if this could > > go into the kernel as well and provide a base for further accelerated > > cryptographic support. > > I'm still a bit skeptical of the usefulness of a standalone "ghash" > implementation, when in practice it will only be used as part of "gcm(aes)". > Directly implementing "gcm(aes)" (instead of relying on crypto/gcm.c to compose > "ghash" and "ctr(aes)") also allows some performance optimizations. > > I asked about this on v4 > (https://lore.kernel.org/linux-crypto/ZCSG71bRuTzVutdm@gmail.com/), > but I didn't receive a response. > > Any thoughts on this? somehow I always seem to overlook this when adapting the series :-( I guess for me the main gcm was always a stepping stone to get started and extend later. This is my first rodeo with crypto stuff in the kernel, so this looks like a manageable chunk and as can be seen by the discussion we had about licensing brings enough topics on its own :-) . Heiko