Re: [PATCH v5 4/4] RISC-V: crypto: add accelerated GCM GHASH implementation

Heiko Stübner
2023-07-07T17:58:18Z

Am Freitag, 16. Juni 2023, 12:34:55 CEST schrieb Herbert Xu:
> On Mon, Jun 12, 2023 at 11:04:42PM +0200, Heiko Stuebner wrote:
> >
> > +struct riscv64_ghash_ctx {
> > + void (*ghash_func)(u64 Xi[2], const u128 Htable[16],
> > + const u8 *inp, size_t len);
> > +
> > + /* key used by vector asm */
> > + u128 htable[16];
> > + /* key used by software fallback */
> > + be128 key;
>
> Where is the fallback?

Thanks for catching this. The fallback is of course not needed for the
Zbc-based variants but only for the future vector-based variants.

So this should not be in here but instead get added once its user is too.
I've moved this over to that part, that I'll post separately.

Heiko