Re: [PATCH 7/7] acpi, apei, ghes: Factor out ioremap virtual memory for IRQ and NMI context.

Borislav Petkov
2014-05-14T17:14:54Z

On Wed, Apr 09, 2014 at 05:14:35PM +0200, Tomasz Nowicki wrote:
> @@ -310,6 +310,8 @@ static void ghes_copy_tofrom_phys(void *buffer, u64 paddr, u32 len,
> u64 offset;
> u32 trunk;
>
> + BUG_ON(in_nmi && !IS_ENABLED(CONFIG_ACPI_APEI_NMI));
> +

That's a good idea but it should be in the NMI notifier
ghes_notify_nmi() instead and simpler:

BUG_ON(!IS_ENABLED(CONFIG_ACPI_APEI_NMI));

> while (len > 0) {
> offset = paddr - (paddr & PAGE_MASK);
> if (in_nmi) {

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--